feat: Sync from noir (#6801)

Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: place return value witnesses directly after function arguments
(noir-lang/noir#5142)
fix(experimental elaborator): Fix frontend tests when `--use-elaborator`
flag is specified (noir-lang/noir#5145)
chore: Remove unused `new_variables` argument from `resolve_type_inner`
(noir-lang/noir#5148)
chore: Remove hir to ast pass
(noir-lang/noir#5147)
fix(experimental elaborator): Fix definition kind of globals and tuple
patterns with `--use-elaborator` flag
(noir-lang/noir#5139)
chore: default to using bn254 in `noirc_frontend`
(noir-lang/noir#5144)
fix(experimental elaborator): Fix `impl Trait` when `--use-elaborator`
is selected (noir-lang/noir#5138)
fix: wrapping in signed division
(noir-lang/noir#5134)
chore(ci): don't raise MSRV issue if workflow cancelled
(noir-lang/noir#5143)
fix: use predicate for curve operations
(noir-lang/noir#5076)
fix(experimental elaborator): Fix global values used in the elaborator
(noir-lang/noir#5135)
fix(experimental elaborator): Clear generics after elaborating type
aliases (noir-lang/noir#5136)
fix(frontend): Resolve object types from method calls a single time
(noir-lang/noir#5131)
feat: Separate runtimes of SSA functions before inlining
(noir-lang/noir#5121)
chore: run all test programs in brillig as well as ACIR
(noir-lang/noir#5128)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: guipublic <[email protected]>
Co-authored-by: guipublic <[email protected]>
Co-authored-by: Maddiaa0 <[email protected]>

cpp/src/barretenberg/dsl/acir_format/ec_operations.cpp

@@ -35,10 +35,10 @@ void create_ec_add_constraint(Builder& builder, const EcAdd& input, bool has_val
     cycle_group_ct input2_point(x2, y2, infinite2);
     // Addition
     cycle_group_ct result = input1_point + input2_point;
-
-    auto x_normalized = result.x.normalize();
-    auto y_normalized = result.y.normalize();
-    auto infinite = result.is_point_at_infinity().normalize();
+    cycle_group_ct standard_result = result.get_standard_form();
+    auto x_normalized = standard_result.x.normalize();
+    auto y_normalized = standard_result.y.normalize();
+    auto infinite = standard_result.is_point_at_infinity().normalize();
     builder.assert_equal(x_normalized.witness_index, input.result_x);
     builder.assert_equal(y_normalized.witness_index, input.result_y);
     builder.assert_equal(infinite.witness_index, input.result_infinite);

cpp/src/barretenberg/dsl/acir_format/multi_scalar_mul.cpp

@@ -36,7 +36,7 @@ template <typename Builder> void create_multi_scalar_mul_constraint(Builder& bui
     }
 
     // Call batch_mul to multiply the points and scalars and sum the results
-    auto output_point = cycle_group_ct::batch_mul(points, scalars);
+    auto output_point = cycle_group_ct::batch_mul(points, scalars).get_standard_form();
 
     // Add the constraints
     builder.assert_equal(output_point.x.get_witness_index(), input.out_point_x);