-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gas Utils for L1 operations #9834
Merged
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
7dca6df
feat: Gas Utils for L1 operations
spypsy 8a0edaa
undo irrelevant change
spypsy fdfc143
update some logging
spypsy df22c32
Merge branch 'master' into spy/gas-utils
spypsy 347d750
add e2e test
spypsy d01a316
add to E2E test config
spypsy 78f8fb2
Merge branch 'master' into spy/gas-utils
spypsy 427c836
rm old import
spypsy 1adc20e
small fixes
spypsy b481eb2
rm pk logging
spypsy 13d731a
formatting & test issues
spypsy e688b8d
formatting
spypsy b280ed4
don't fail script when ADDRESS & pk are unset
spypsy 58bcc71
remove logs
spypsy 2261352
update default private_key assignment in validator.sh
spypsy 7092327
use const for WEI
spypsy 1b4c8c3
skip PRIVATE_KEY assignment
spypsy 31449f7
WIP: PR fixes
spypsy 9af92ea
Merge branch 'master' into spy/gas-utils
spypsy d066d51
refactor GasUtils
spypsy f96b1d8
simplify acc & wallets
spypsy e18c4f9
bump priorityFee on retries
spypsy f853f21
configs
spypsy 569bf2d
Merge branch 'master' into spy/gas-utils
spypsy b3223d7
rename to L1TxUtils
spypsy 47f15a4
don't use 0x
spypsy 03fbf79
send contract deployments to null
spypsy 280c9a7
fix publisher tests
spypsy 0b45fe6
fix getNodeInfo test
spypsy bb5505b
Merge branch 'master' into spy/gas-utils
spypsy 653a083
split sendTx & monitorTx for separate use
spypsy c15d6b1
calc nonce in monitor function
spypsy 9508cb7
fix null-check
spypsy 81c03e7
Merge branch 'master' into spy/gas-utils
spypsy d80ece6
remove from e2e config
spypsy 47edcd8
temp fix integration publisher test
spypsy d1fa404
temp fix integration publisher test
spypsy 09339a4
some PR fixes
spypsy a331d9e
use default-defined value
spypsy 1b169b4
more PR fixes
spypsy 8818d1f
10% min fee bump, ensure test sends replacement tx
spypsy 60afdea
merge conflicts
spypsy 2c4858d
Merge branch 'master' into spy/gas-utils
spypsy c2338d0
Merge branch 'master' into spy/gas-utils
spypsy 34170d1
undo submodule changes
spypsy 3d46d87
fix get-node-info opts
spypsy af2d3e6
requesting info from node, not pxe
spypsy 4ab1d4b
Merge branch 'master' into spy/gas-utils
spypsy 0834d50
More PR fixes
spypsy 0c20390
fix await
spypsy 5fd231b
add cheat codes
spypsy a17a0ae
expect two error calls
spypsy 0c84a64
update l1-publisher tests
spypsy de03935
add priorityFee to maxFeePerGas calculation, retry fetching l1 tx
spypsy e62ba9c
fix priorityFee addition, add gas calculationt ests
spypsy e4cc25f
Merge branch 'master' into spy/gas-utils
spypsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should happen before the
maxFeePerGas = maxFeePerGas > minMaxFee ? maxFeePerGas : minMaxFee
, since theminMaxFee
already has the priority fee component accounted for.Otherwise, if
maxFeePerGas
gets set tominMaxFee
and then we addpriorityFee
on top of it, we'd be accounting for thepriorityFee
twice.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right ofc 🤦