-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove note processor and trigger sync #9794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gj/process_tagged_logs
… gj/process_tagged_logs
…ec-packages into gj/trigger_note_sync
… gj/trigger_note_sync
… gj/trigger_note_sync
Co-authored-by: Nicolás Venturo <[email protected]>
Co-authored-by: Nicolás Venturo <[email protected]>
Co-authored-by: Nicolás Venturo <[email protected]>
…ec-packages into gj/process_tagged_logs
nventuro
reviewed
Nov 12, 2024
yarn-project/end-to-end/src/e2e_pending_note_hashes_contract.test.ts
Outdated
Show resolved
Hide resolved
… gj/trigger_note_sync
… gj/trigger_note_sync
…-packages into gj/trigger_note_sync
… gj/trigger_note_sync
nventuro
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In it goes!
…-packages into gj/trigger_note_sync
… gj/trigger_note_sync
… gj/trigger_note_sync
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9370
Closes #9575
Closes #9786
Replaces the note processor with the tagging approach, supporting a sliding window of indexes and partial notes