Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve witness generation for cycle_group::batch_mul #9563

Merged
merged 23 commits into from
Jan 6, 2025
Merged

feat: improve witness generation for cycle_group::batch_mul #9563

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
35475e2
wip
zac-williamson Oct 29, 2024
8cb78b5
cycle_group::batch_mul batches modular inversions during witness gene…
zac-williamson Oct 30, 2024
7b80a03
removed x_coordinate_check from straus_lookup_table
zac-williamson Oct 30, 2024
850db1b
removed debug code
zac-williamson Oct 30, 2024
ca6da54
minor optimization to remove 12 gates per mul in `batch_mul` when the…
zac-williamson Oct 30, 2024
a6f4335
wip
zac-williamson Oct 30, 2024
78c9b26
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Oct 30, 2024
1e1668f
minor efficiency improvements for straus_lookup_table constructor
zac-williamson Oct 30, 2024
96cedff
disabled join split circuit change test
zac-williamson Nov 5, 2024
2dcde30
compiler fix
zac-williamson Nov 6, 2024
6be66d3
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Nov 6, 2024
0a5ee12
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 11, 2024
f841ba0
fixed wasm compiler error
zac-williamson Dec 11, 2024
45c060f
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 11, 2024
4959284
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 12, 2024
267d8ad
added comments and added back in join_split_test
zac-williamson Dec 12, 2024
a9f0629
added missing hint description
zac-williamson Dec 12, 2024
197cf5d
grammar
zac-williamson Dec 12, 2024
6365a91
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 12, 2024
4379bfb
PR comments
zac-williamson Dec 20, 2024
95d3816
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 20, 2024
bbbe849
Merge branch 'master' into zw/cycle-group-witgen
zac-williamson Dec 20, 2024
ce032f0
Update circuit hash
codygunton Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/examples/join_split/join_split.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ TEST_F(join_split_tests, test_0_input_notes_and_detect_circuit_change)
// The below part detects any changes in the join-split circuit
constexpr size_t DYADIC_CIRCUIT_SIZE = 1 << 16;

constexpr uint256_t CIRCUIT_HASH("0xe833d0ffaa99f39ca31ef79ded0089b0ec614eb4a528c4e1c4af6221a003fa6e");
constexpr uint256_t CIRCUIT_HASH("0x727924c3ea2266dc2b6a38f335019c26a941911d5991f25adb3ce9c288af7751");

const uint256_t circuit_hash = circuit.hash_circuit();
// circuit is finalized now
Expand Down
Loading
Loading