Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not increment reference counts on arrays through references #9484

Closed
wants to merge 2 commits into from

Conversation

TomAFrench
Copy link
Member

Testing noir-lang/noir#6375 against aztec-packages.

Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 9d772b963c587a017eadc76c63e25778caaa357d, compared to commit: a6d8f488b1dba07efa5bf7a68eed3c49b1918f97

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
Auth::set_authorized_delay +428 ❌ +7.59%
Auth::set_authorized +428 ❌ +7.49%
Token::burn_public +146 ❌ +3.10%
TokenBlacklist::get_roles +56 ❌ +2.16%
InclusionProofs::constructor +52 ❌ +2.12%
AuthRegistry::consume +62 ❌ +2.04%
FPC::constructor +52 ❌ +1.82%
Uniswap::constructor +52 ❌ +1.82%
Auth::constructor +52 ❌ +1.80%
EasyPrivateVoting::constructor +52 ❌ +1.72%
StatefulTest::public_constructor +52 ❌ +1.61%
Crowdfunding::init +52 ❌ +1.56%
TokenBlacklist::mint_public +67 ❌ +1.55%
AppSubscription::constructor +52 ❌ +1.50%
InclusionProofs::public_dispatch +52 ❌ +1.32%
TokenBlacklist::mint_private +52 ❌ +1.28%
Lending::public_dispatch +253 ❌ +1.01%
AppSubscription::public_dispatch +40 ❌ +0.84%
Crowdfunding::public_dispatch +26 ❌ +0.44%
AvmTest::public_dispatch +187 ❌ +0.34%
Parent::public_dispatch +21 ❌ +0.26%
AvmTest::bulk_testing +36 ❌ +0.15%
TokenBlacklist::public_dispatch +6 ❌ +0.02%
AuthRegistry::public_dispatch -15 ✅ -0.19%
Token::public_dispatch -75 ✅ -0.23%
Uniswap::public_dispatch -74 ✅ -0.33%
Auth::public_dispatch -39 ✅ -0.38%
AvmInitializerTest::public_dispatch -13 ✅ -0.42%
EasyPrivateVoting::public_dispatch -26 ✅ -0.45%
Uniswap::swap_public -65 ✅ -0.47%
Test::consume_message_from_arbitrary_sender_public -39 ✅ -0.51%
Lending::_withdraw -39 ✅ -0.53%
Lending::_borrow -39 ✅ -0.54%
StaticParent::public_dispatch -32 ✅ -0.55%
AvmInitializerTest::constructor -13 ✅ -0.55%
AuthWitTest::public_dispatch -13 ✅ -0.62%
Test::public_dispatch -121 ✅ -0.64%
Token::complete_refund -39 ✅ -0.67%
TokenBridge::exit_to_l1_public -52 ✅ -0.68%
TokenBridge::claim_public -78 ✅ -0.68%
AvmTest::sha256_hash -26 ✅ -0.69%
Lending::update_accumulator -39 ✅ -0.73%
Lending::_repay -39 ✅ -0.73%
Test::consume_mint_public_message -78 ✅ -0.77%
CardGame::start_game -52 ✅ -0.78%
CardGame::on_cards_claimed -65 ✅ -0.93%
Lending::get_position -47 ✅ -0.97%
TokenBridge::public_dispatch -206 ✅ -0.98%
DocsExample::public_dispatch -52 ✅ -1.00%
FPC::public_dispatch -89 ✅ -1.08%
Spam::public_dispatch -39 ✅ -1.09%
Parent::public_nested_static_call -39 ✅ -1.11%
NFT::public_dispatch -303 ✅ -1.19%
Token::mint_private -39 ✅ -1.20%
NFT::_finalize_transfer_to_private_unsafe -78 ✅ -1.24%
NFT::finalize_transfer_to_private -78 ✅ -1.25%
StatefulTest::public_dispatch -91 ✅ -1.25%
Benchmarking::increment_balance -39 ✅ -1.26%
Token::mint_public -43 ✅ -1.30%
Lending::init -39 ✅ -1.31%
NFT::mint -43 ✅ -1.38%
CardGame::on_game_joined -65 ✅ -1.39%
TokenBlacklist::_increase_public_balance -39 ✅ -1.47%
Token::_increase_public_balance -39 ✅ -1.47%
Spam::public_spam -39 ✅ -1.49%
FeeJuice::public_dispatch -95 ✅ -1.61%
Token::assert_minter_and_mint -39 ✅ -1.62%
Lending::_deposit -39 ✅ -1.63%
NFT::owner_of -43 ✅ -1.66%
FeeJuice::check_balance -39 ✅ -1.74%
Auth::get_authorized_delay -39 ✅ -1.76%
FeeJuice::_increase_public_balance -43 ✅ -1.78%
EasyPrivateVoting::add_to_tally_public -43 ✅ -1.82%
Lending::get_asset -39 ✅ -1.90%
NFT::set_minter -39 ✅ -1.90%
Token::set_minter -39 ✅ -1.91%
Claim::public_dispatch -78 ✅ -1.94%
StatefulTest::increment_public_value -39 ✅ -1.94%
AvmTest::add_storage_map -43 ✅ -1.96%
StatefulTest::increment_public_value_no_init_check -39 ✅ -1.97%
PrivateFPC::public_dispatch -78 ✅ -1.99%
TokenBlacklist::balance_of_public -39 ✅ -1.99%
Token::balance_of_public -39 ✅ -1.99%
FeeJuice::balance_of_public -39 ✅ -2.03%
Auth::get_authorized -39 ✅ -2.05%
Benchmarking::public_dispatch -104 ✅ -2.07%
NFT::is_minter -39 ✅ -2.08%
Token::is_minter -39 ✅ -2.08%
Benchmarking::broadcast -39 ✅ -2.10%
PriceFeed::get_price -39 ✅ -2.10%
AuthRegistry::is_reject_all -39 ✅ -2.13%
StatefulTest::get_public_value -39 ✅ -2.14%
PriceFeed::set_price -39 ✅ -2.15%
AuthRegistry::is_consumable -43 ✅ -2.15%
Auth::get_scheduled_authorized -39 ✅ -2.15%
AvmTest::read_storage_map -39 ✅ -2.15%
CardGame::public_dispatch -344 ✅ -2.19%
NFT::_finish_transfer_to_public -39 ✅ -2.19%
AuthRegistry::_set_authorized -43 ✅ -2.24%
AuthRegistry::set_reject_all -39 ✅ -2.26%
AuthRegistry::set_authorized -43 ✅ -2.28%
AvmTest::set_storage_map -43 ✅ -2.35%
TestLog::public_dispatch -78 ✅ -2.48%
PriceFeed::public_dispatch -95 ✅ -2.50%
AvmTest::get_args_hash -43 ✅ -2.52%
Claim::constructor -78 ✅ -2.54%
TokenBridge::constructor -78 ✅ -2.56%
Router::public_dispatch -63 ✅ -2.63%
PrivateFPC::constructor -78 ✅ -2.63%
AvmTest::poseidon2_hash -43 ✅ -2.63%
ImportTest::public_dispatch -52 ✅ -3.04%
CardGame::on_card_played -211 ✅ -3.79%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
Auth::set_authorized_delay 6,065 (+428) +7.59%
Auth::set_authorized 6,145 (+428) +7.49%
Token::burn_public 4,849 (+146) +3.10%
TokenBlacklist::get_roles 2,644 (+56) +2.16%
InclusionProofs::constructor 2,504 (+52) +2.12%
AuthRegistry::consume 3,099 (+62) +2.04%
FPC::constructor 2,911 (+52) +1.82%
Uniswap::constructor 2,911 (+52) +1.82%
Auth::constructor 2,936 (+52) +1.80%
EasyPrivateVoting::constructor 3,074 (+52) +1.72%
StatefulTest::public_constructor 3,276 (+52) +1.61%
Crowdfunding::init 3,376 (+52) +1.56%
TokenBlacklist::mint_public 4,389 (+67) +1.55%
AppSubscription::constructor 3,523 (+52) +1.50%
InclusionProofs::public_dispatch 4,000 (+52) +1.32%
TokenBlacklist::mint_private 4,121 (+52) +1.28%
Lending::public_dispatch 25,329 (+253) +1.01%
AppSubscription::public_dispatch 4,804 (+40) +0.84%
Crowdfunding::public_dispatch 5,894 (+26) +0.44%
AvmTest::public_dispatch 55,287 (+187) +0.34%
Parent::public_dispatch 7,997 (+21) +0.26%
AvmTest::bulk_testing 23,284 (+36) +0.15%
TokenBlacklist::public_dispatch 24,326 (+6) +0.02%
AuthRegistry::public_dispatch 7,969 (-15) -0.19%
Token::public_dispatch 32,050 (-75) -0.23%
Uniswap::public_dispatch 22,655 (-74) -0.33%
Auth::public_dispatch 10,145 (-39) -0.38%
AvmInitializerTest::public_dispatch 3,091 (-13) -0.42%
EasyPrivateVoting::public_dispatch 5,693 (-26) -0.45%
Uniswap::swap_public 13,635 (-65) -0.47%
Test::consume_message_from_arbitrary_sender_public 7,589 (-39) -0.51%
Lending::_withdraw 7,300 (-39) -0.53%
Lending::_borrow 7,244 (-39) -0.54%
StaticParent::public_dispatch 5,802 (-32) -0.55%
AvmInitializerTest::constructor 2,355 (-13) -0.55%
AuthWitTest::public_dispatch 2,098 (-13) -0.62%
Test::public_dispatch 18,832 (-121) -0.64%
Token::complete_refund 5,819 (-39) -0.67%
TokenBridge::exit_to_l1_public 7,651 (-52) -0.68%
TokenBridge::claim_public 11,420 (-78) -0.68%
AvmTest::sha256_hash 3,750 (-26) -0.69%
Lending::update_accumulator 5,340 (-39) -0.73%
Lending::_repay 5,314 (-39) -0.73%
Test::consume_mint_public_message 10,088 (-78) -0.77%
CardGame::start_game 6,625 (-52) -0.78%
CardGame::on_cards_claimed 6,924 (-65) -0.93%
Lending::get_position 4,820 (-47) -0.97%
TokenBridge::public_dispatch 20,797 (-206) -0.98%
DocsExample::public_dispatch 5,156 (-52) -1.00%
FPC::public_dispatch 8,147 (-89) -1.08%
Spam::public_dispatch 3,541 (-39) -1.09%
Parent::public_nested_static_call 3,477 (-39) -1.11%
NFT::public_dispatch 25,159 (-303) -1.19%
Token::mint_private 3,224 (-39) -1.20%
NFT::_finalize_transfer_to_private_unsafe 6,214 (-78) -1.24%
NFT::finalize_transfer_to_private 6,183 (-78) -1.25%
StatefulTest::public_dispatch 7,212 (-91) -1.25%
Benchmarking::increment_balance 3,068 (-39) -1.26%
Token::mint_public 3,255 (-43) -1.30%
Lending::init 2,940 (-39) -1.31%
NFT::mint 3,082 (-43) -1.38%
CardGame::on_game_joined 4,624 (-65) -1.39%
TokenBlacklist::_increase_public_balance 2,621 (-39) -1.47%
Token::_increase_public_balance 2,621 (-39) -1.47%
Spam::public_spam 2,578 (-39) -1.49%
FeeJuice::public_dispatch 5,800 (-95) -1.61%
Token::assert_minter_and_mint 2,366 (-39) -1.62%
Lending::_deposit 2,355 (-39) -1.63%
NFT::owner_of 2,548 (-43) -1.66%
FeeJuice::check_balance 2,199 (-39) -1.74%
Auth::get_authorized_delay 2,172 (-39) -1.76%
FeeJuice::_increase_public_balance 2,378 (-43) -1.78%
EasyPrivateVoting::add_to_tally_public 2,321 (-43) -1.82%
Lending::get_asset 2,019 (-39) -1.90%
NFT::set_minter 2,011 (-39) -1.90%
Token::set_minter 2,006 (-39) -1.91%
Claim::public_dispatch 3,948 (-78) -1.94%
StatefulTest::increment_public_value 1,969 (-39) -1.94%
AvmTest::add_storage_map 2,146 (-43) -1.96%
StatefulTest::increment_public_value_no_init_check 1,936 (-39) -1.97%
PrivateFPC::public_dispatch 3,834 (-78) -1.99%
TokenBlacklist::balance_of_public 1,916 (-39) -1.99%
Token::balance_of_public 1,916 (-39) -1.99%
FeeJuice::balance_of_public 1,878 (-39) -2.03%
Auth::get_authorized 1,863 (-39) -2.05%
Benchmarking::public_dispatch 4,916 (-104) -2.07%
NFT::is_minter 1,834 (-39) -2.08%
Token::is_minter 1,834 (-39) -2.08%
Benchmarking::broadcast 1,822 (-39) -2.10%
PriceFeed::get_price 1,814 (-39) -2.10%
AuthRegistry::is_reject_all 1,796 (-39) -2.13%
StatefulTest::get_public_value 1,786 (-39) -2.14%
PriceFeed::set_price 1,774 (-39) -2.15%
AuthRegistry::is_consumable 1,955 (-43) -2.15%
Auth::get_scheduled_authorized 1,771 (-39) -2.15%
AvmTest::read_storage_map 1,771 (-39) -2.15%
CardGame::public_dispatch 15,360 (-344) -2.19%
NFT::_finish_transfer_to_public 1,741 (-39) -2.19%
AuthRegistry::_set_authorized 1,874 (-43) -2.24%
AuthRegistry::set_reject_all 1,689 (-39) -2.26%
AuthRegistry::set_authorized 1,843 (-43) -2.28%
AvmTest::set_storage_map 1,790 (-43) -2.35%
TestLog::public_dispatch 3,064 (-78) -2.48%
PriceFeed::public_dispatch 3,705 (-95) -2.50%
AvmTest::get_args_hash 1,663 (-43) -2.52%
Claim::constructor 2,996 (-78) -2.54%
TokenBridge::constructor 2,963 (-78) -2.56%
Router::public_dispatch 2,332 (-63) -2.63%
PrivateFPC::constructor 2,887 (-78) -2.63%
AvmTest::poseidon2_hash 1,589 (-43) -2.63%
ImportTest::public_dispatch 1,658 (-52) -3.04%
CardGame::on_card_played 5,363 (-211) -3.79%

@TomAFrench TomAFrench closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant