refactor: requiring only 1 sig from user

[benesjan]

Fixes #8098

[benesjan]

• refactor: requiring only 1 sig from user #8146 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[benesjan]

i decided to go with the combined payload hash because it seems good enough and it required much less time than somehow merging AppPayload and FeePayload into 1 struct. Given that this is not enshrined in protocol I think we don't need to chase perfection here (that would require monster refactor).

On an unrelated note. I think we could optimize this a bit more and just add the app payload and fee payload hashes instead of hashing them because as far as I know we don't really need the robust crypto properties on the outer hash here. But seems to make sense to do that later if it turns out we need to hyper optimize this.

[benesjan]

I think we could optimize this a bit more and just add the app payload and fee payload hashes

Thinking about this more this could theoretically make it possible to swap the order in which fee payload and app payload are executed so it doesn't seem like a good idea.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 777 (-48%)
• avm_simulation_time_ms (Token:transfer_public): 34.9 (+73%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,778	1,566	707 (-2%)	746 (-3%)	778
proof_construction_time_sha256_30_ms	11,567	3,099	1,381	1,424 (-1%)	1,466
proof_construction_time_sha256_100_ms	44,183	11,931 (+1%)	5,449	5,404	5,776 (-1%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	58.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,538	423	201	229 (+1%)	271 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,676	1,519	677	746 (+3%)	754 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,660	92,482	177,716
l1_rollup_execution_gas	1,373,688	2,107,406	3,892,696
l2_block_processing_time_in_ms	264 (+9%)	446 (+2%)	814 (+4%)
l2_block_building_time_in_ms	9,078 (+1%)	17,529	34,972 (+1%)
l2_block_rollup_simulation_time_in_ms	9,078 (+1%)	17,528	34,972 (+1%)
l2_block_public_tx_process_time_in_ms	7,649 (+1%)	16,006	33,437 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,033 (+2%)	3,859 (+1%)
node_database_size_in_bytes	12,595,280	16,666,704
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	85.8 (-5%)	377 (-5%)	21,755	44,860	N/A
private-kernel-inner	171 (+3%)	673 (-6%)	72,566	45,007	N/A
private-kernel-reset-tiny	458	835 (-4%)	65,675	44,846	N/A
private-kernel-tail	195	154 (-3%)	50,686	52,257	N/A
base-parity	5.54	N/A	160	96.0	N/A
root-parity	35.0 (-2%)	N/A	73,948	96.0	N/A
base-rollup	2,755	N/A	189,136	664	N/A
root-rollup	39.6 (-1%)	N/A	58,173	716	N/A
public-kernel-setup	82.6	N/A	105,085	71,222	N/A
public-kernel-app-logic	95.3	N/A	104,911	71,222	N/A
public-kernel-tail	553 (+1%)	N/A	410,534	16,414	N/A
private-kernel-reset-small	451 (-2%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 777 (-48%)	623 (-4%)	460,796	1,825	N/A
public-kernel-teardown	82.2 (-2%)	N/A	105,349	71,222	N/A
merge-rollup	20.0	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	81,945 (+1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	404
FeeJuice:deploy	1,376	11,731	390 (+1%)
SchnorrAccount:constructor	1,312	11,731	73.4 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	396 (-3%)
Token:privately_mint_private_note	1,280	11,731	100 (+1%)
FPC:fee_entrypoint_public	1,344	11,731	28.6 (+5%)
Token:transfer	1,312	11,731	224 (-2%)
Benchmarking:create_note	1,344	11,731	86.4 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4 (-1%)
Token:unshield	1,376	11,731	520 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	704 (+1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	54.3 (-5%)	7,739
FeeJuice:set_portal	9.26 (-2%)	2,354
Token:constructor	82.6 (-13%)	26,051
FPC:constructor	53.4 (-2%)	18,001
FeeJuice:mint_public	38.9 (-2%)	5,877
Token:mint_public	45.2 (+3%)	10,917
Token:assert_minter_and_mint	65.5	7,512
AuthRegistry:set_authorized	46.8	4,391
FPC:prepare_fee	239 (+2%)	7,043
Token:transfer_public	⚠️ 34.9 (+73%)	39,426
FPC:pay_refund	54.2 (-9%)	10,234
Benchmarking:increment_balance	938	6,563
Token:_increase_public_balance	39.3 (-3%)	8,433
FPC:pay_refund_with_shielded_rebate	62.2	10,783

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.168 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18	3.86 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.109 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.6 (+1%)	18.4 (+5%)	31.2 (+1%)	60.5 (+3%)	118 (+7%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.111	0.107 (+4%)	0.101 (+1%)	0.104 (+3%)	0.105 (+5%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	25.9 (+2%)	43.9	82.7 (+1%)	163 (+3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111 (+1%)	0.104 (+1%)	0.106 (+1%)	0.102 (+1%)	0.100
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.4 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |