Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Events in contract artifacts #2786

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

sirasistant
Copy link
Collaborator

@sirasistant sirasistant commented Oct 11, 2023

Closes #2324

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@sirasistant sirasistant changed the title Arv/events in artifacts feat: Events in contract artifacts Oct 11, 2023
@sirasistant sirasistant marked this pull request as ready for review October 11, 2023 10:40
@sirasistant sirasistant requested a review from benesjan October 11, 2023 10:40
@sirasistant sirasistant enabled auto-merge (squash) October 11, 2023 10:40
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45444 179588 716132
l1_rollup_calldata_gas 222972 867860 3449576
l1_rollup_execution_gas 842059 3594968 22204945
l2_block_processing_time_in_ms 1037 3936 15586
note_successful_decrypting_time_in_ms 327 1004 3688
note_trial_decrypting_time_in_ms 29 107 138
l2_block_building_time_in_ms 8965 36114 149803
l2_block_rollup_simulation_time_in_ms 6655 26845 105831
l2_block_public_tx_process_time_in_ms 2270 9142 43515

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 10 blocks 20 blocks 30 blocks
node_history_sync_time_in_ms 30702 75429 135541
note_history_successful_decrypting_time_in_ms 4502 13045 19938
note_history_trial_decrypting_time_in_ms 236 251 251
node_database_size_in_bytes 1196197 1901991 2755406
pxe_database_size_in_bytes 54187 108338 162578

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 56.23312883435583 56577 14745
private-kernel-ordering 30.233128834355828 20137 8089
base-rollup 870 631604 810
root-rollup 37.75609756097561 4072 1097
private-kernel-inner 51.86882716049383 72288 14745
public-kernel-private-input 51.24382716049383 37359 14745
public-kernel-non-first-iteration 31.209876543209877 37401 14745
merge-rollup 0.9534883720930233 2592 873

@sirasistant sirasistant merged commit b8cb7df into master Oct 11, 2023
@sirasistant sirasistant deleted the arv/events_in_artifacts branch October 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include events in Noir contract artifacts
3 participants