chore(ci3): refactor ci3.yml, fix external PR flow #12037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ludamad
commented
Feb 16, 2025
•
ludamad
commented
- Refactor amd64 and arm64 to be a single ci task with a matrix
- Fix the logic around external PRs, control this with a ci-external label
ludamad
added
arm64-ci
ludamad
commented
Feb 20, 2025
| @@ -152,6 +152,9 @@ function build { | |||
|
|
|||
| check_toolchains | |||
|
|
|||
| # Ensure we have yarn set up. | |||
ludamad
commented
Feb 20, 2025
| @@ -22,7 +22,7 @@ Private functions can call another private function, and can request to call a p | |||
|
|
|||
| Public functions are simulated and proved on the sequencer side, and verified by the public kernel circuit. | |||
|
|
|||
| The public inputs of public functions is defined [here](../circuits.js/src/structs/avm_circuit_public_inputs.ts). | |||
| The public inputs of public functions is defined [here](../circuits.js/src/structs/avm/avm_circuit_public_inputs.ts). | |||
|
|
|||
| They are run with the assistance of an oracle that provides any value read from the public state tree. | |||
ludamad
commented
Feb 20, 2025
| @@ -27,7 +27,7 @@ Logging goes through the [Logger](yarn-project/foundation/src/log/) module in Ty | |||
|
|
|||
| ## Releases | |||
|
|
|||
| Releases are driven by [release-please](https://github.com/googleapis/release-please), which maintains a 'Release PR' containing an updated CHANGELOG.md since the last release. Triggering a new release is simply a case of merging this PR to master. A [github workflow](./.github/workflows/release_please.yml) will create the tagged release triggering ./bootstrap.sh release to build and deploy the version at that tag. | |||
ludamad
commented
Feb 20, 2025
| @@ -171,6 +171,12 @@ | |||
| }, | |||
| "files.trimTrailingWhitespace": true, | |||
| "files.insertFinalNewline": true, | |||
| "[rust]": { | |||
| "files.trimTrailingWhitespace": false | |||
| }, | |||
There was a problem hiding this comment.
bundled request from Tom
sklppy88
approved these changes
Feb 20, 2025
| fail-fast: false | ||
| matrix: | ||
| # Only run arm64 build with arm64-ci label. | ||
| # Thhe way to do conditions here is to parse full strings as JSON. |
There was a problem hiding this comment.
Suggested change
| # Thhe way to do conditions here is to parse full strings as JSON. | |
| # The way to do conditions here is to parse full strings as JSON. |
TomAFrench
added a commit
that referenced
this pull request
Feb 20, 2025
* master: (300 commits) fix(ci): don't have checks go green immediately (#12168) fix: ASSERTS that should throw (#12167) fix: retry rm operation in cleanup (#12162) chore: Fix linter errors (#12164) feat: Barretenberg C++ binary overhaul (#11459) fix: call install_hooks in bootstrap (#12159) chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140) test: verify proving is resumed after broker crash (#11122) chore(ci3): update ci.md with swc notes (#12147) fix: don't try to get bench artifacts on external PR (#12157) feat: partial note handling in aztec-nr (#12122) fix: external fixes pt 2 (#12153) chore: fix message path (#12150) chore(ci3): refactor ci3.yml, fix external PR flow (#12037) fix: Do not try flushing txs in bot setup if not set (#12144) chore: Silence warns on invalid bootnode enr (#12135) fix: don't early-out on test fails (#12143) feat(avm): deduplicating event emitters (#12137) chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133) test: kill prover node and see it recover (#11118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.