feat(avm): interaction testing #11947

fcarreiro · 2025-02-12T16:16:40Z

See dummy example in execution.test.cpp (constraining).
Interactions are tested by computing the polynomials first.

Caveats:

As usual, you need to leave an empty first row for shifts to work, if you use shifts.
These tests are, per interaction, 160x slower than normal tests.
You can't use the interactive debugger to debug inverses, but you still can use it to debug anything on the trace before you call check_interaction.

fcarreiro · 2025-02-12T16:17:01Z

feat(avm): relation microbenchmarks #11974
chore(avm): tracegen interactions assertion #11972
feat(avm): interaction testing #11947 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

fcarreiro · 2025-02-12T16:18:48Z

barretenberg/cpp/src/barretenberg/vm2/constraining/polynomials.cpp

@@ -0,0 +1,93 @@
+#include "barretenberg/vm2/constraining/polynomials.hpp"


Moved from proving_helper.

fcarreiro · 2025-02-12T16:21:45Z

barretenberg/cpp/src/barretenberg/vm2/constraining/testing/check_relation.hpp

@@ -27,13 +46,26 @@ void check_relation_internal(const Trace& trace, std::span<size_t> subrelations)
            }
        }
    }
+    // For all subrelations, the result should be zero at the end of the trace.


I changed this to work both with linearly dependent or independent subrelations. The dependent ones are only checked at the end.

fcarreiro · 2025-02-12T16:22:20Z

barretenberg/cpp/src/barretenberg/vm2/constraining/testing/check_relation.hpp

+    }
+}
+
+template <typename Relation, typename Trace, typename RowGetter>


I needed to template how to get the row, because it works differently on traces and polynomials.

fcarreiro · 2025-02-12T16:23:52Z

barretenberg/cpp/src/barretenberg/vm2/tracegen/lib/interaction_builder.hpp

@@ -10,4 +10,14 @@ class InteractionBuilderInterface {
    virtual void process(TraceContainer& trace) = 0;
 };

+// We set a dummy value in the inverse column so that the size of the column is right.
+// The correct value will be set by the prover.
+template <typename LookupSettings> void SetDummyInverses(TraceContainer& trace)


I factored this out. It's clearer and it shouldn't hurt the theoretical complexity.

fcarreiro · 2025-02-12T16:24:33Z

barretenberg/cpp/src/barretenberg/vm2/tracegen/trace_container.hpp

@@ -55,7 +55,7 @@ class TraceContainer {
    // Observe that therefore concurrent write access to different columns is cheap.
    struct SparseColumn {
        std::shared_mutex mutex;
-        uint32_t max_row_number = 0;
+        int64_t max_row_number = -1;


This is a fix. I was always reporting at least 1 row.

Same question/comment

-1 means that the columns is empty, therefore no max row number. Added comment.

dbanks12

Looks good to me! But I would have @IlyasRidhuan and/or @jeanmon review as well.

dbanks12 · 2025-02-12T16:57:19Z

barretenberg/cpp/src/barretenberg/vm2/constraining/polynomials.cpp

+                           trace.visit_column(col, [&](size_t row, const AvmProver::FF& value) {
+                               // We use `at` because we are sure the row exists and the value is non-zero.
+                               poly.at(row) = value;
+                           });
+                           // We free columns as we go.
+                           // TODO: If we merge the init with the setting, this would be even more memory efficient.
+                           trace.clear_column(col);


I know this file was just moved, but I'd make a comment with a warning that this function kills the trace by clearing the columns.

Done. In the hpp.

dbanks12 · 2025-02-12T17:05:01Z

barretenberg/cpp/src/barretenberg/vm2/tracegen/trace_container.cpp

        const auto it = std::max_element(keys.begin(), keys.end());
-        column_data.max_row_number = it == keys.end() ? 0 : *it;
+        column_data.max_row_number = it == keys.end() ? -1 : static_cast<int64_t>(*it);
        column_data.row_number_dirty = false;


is -1 meant to basically be "max uint" here? maybe add a comment

-1 means that the columns is empty, therefore no max row number. Added comment.

dbanks12 · 2025-02-12T17:05:35Z

barretenberg/cpp/src/barretenberg/vm2/tracegen/trace_container.hpp

@@ -55,7 +55,7 @@ class TraceContainer {
    // Observe that therefore concurrent write access to different columns is cheap.
    struct SparseColumn {
        std::shared_mutex mutex;
-        uint32_t max_row_number = 0;
+        int64_t max_row_number = -1;


Same question/comment

dbanks12 · 2025-02-12T17:08:18Z

bb-pilcom/bb-pil-backend/templates/lookup.hpp.hbs

+        static std::string get_subrelation_label(size_t index) {
+            {{! from generic_lookup_relation.hpp }}
+            if (index == 0) {
+                return "INVERSES_ARE_CORRECT";
+            } else if (index == 1) {
+                return "ACCUMULATION_IS_CORRECT";
+            }
+            return std::to_string(index);
+        }


So do lookups and permutations have 2 subrelations (inverses & accumulation)? If not, this confuses me...

That's right, they have 2 subrelations, but they are not in PIL because the relation code is pure C++ (it's bb's). See generic_lookup_relation.hpp and its accumulate function.

dbanks12 · 2025-02-12T17:08:54Z

barretenberg/cpp/src/barretenberg/vm2/constraining/testing/check_relation.hpp

 #include "barretenberg/vm2/tracegen/test_trace_container.hpp"

 namespace bb::avm2::constraining {
+namespace detail {


why the detail namespace?

It's common in C++ when you want to hide/indicate that this should not be used externally, but you still need to keep it in a header file (templates, etc). In header files you should not use anonymous namespaces, which is what you'd do in cpp files.

dbanks12 · 2025-02-12T17:14:00Z

barretenberg/cpp/src/barretenberg/vm2/constraining/testing/check_relation.hpp

+    // Finally we check the interaction.
+    [&]<size_t... Is>(std::index_sequence<Is...>) {
+        constexpr std::array<size_t, sizeof...(Is)> subrels = { Is... };
+        detail::check_relation_internal<Lookup>(
+            polys, subrels, [](const auto& polys, size_t r) { return polys.get_row(r); });
+    }(std::make_index_sequence<Lookup::SUBRELATION_PARTIAL_LENGTHS.size()>());


Can you comment here a bit more about the the use of the elipses and what Is is? Also why do you need to create a lambda and then call it?

Unfortunately that would require a course in C++ metaprogramming. The person attempting to understand this code will either understand it, or should not modify it 😆 . I can try to explain over huddle some day but really there is no short explanation that would fit in a comment.

IlyasRidhuan

LGTM!

jeanmon · 2025-02-13T10:34:44Z

barretenberg/cpp/src/barretenberg/vm2/constraining/polynomials.hpp

+
+namespace bb::avm2::constraining {
+
+// Computes the polynomials from the trace, and destroys it in the process.


@fcarreiro : If this function destroys the trace, cannot we use std::move mechanism to make it clear that ownership is passed to the function?

I tried, but this function is used in a context where the caller cannot bind to an && reference. A bit complicated. I might make some changes at some point but it was not trivial.

jeanmon · 2025-02-13T10:36:43Z

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/execution.test.cpp

    });
    // clang-format on

    check_relation<execution>(trace);
 }

+// This is just a PoC.
+TEST(ExecutionConstrainingTest, Permutation)


@fcarreiro Do you have any similar test for dynamic lookups?

I didn't write one but it should be the same just changing the permutation for the lookupintodynamic.

jeanmon

Cool work @fcarreiro ! Please look at my comments before merging.

fcarreiro · 2025-02-13T12:05:27Z

Merge activity

Feb 13, 7:05 AM EST: A user merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.76.4</summary> ## [0.76.4](aztec-package-v0.76.3...aztec-package-v0.76.4) (2025-02-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.76.4</summary> ## [0.76.4](barretenberg.js-v0.76.3...barretenberg.js-v0.76.4) (2025-02-13) ### Miscellaneous * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> <details><summary>aztec-packages: 0.76.4</summary> ## [0.76.4](aztec-packages-v0.76.3...aztec-packages-v0.76.4) (2025-02-13) ### Features * `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) ([5efdd57](5efdd57)) * Aes decryption oracle ([#11907](#11907)) ([c4ce913](c4ce913)) * **avm:** Constrained ec_add ([#11525](#11525)) ([f8fe602](f8fe602)) * **avm:** Interaction testing ([#11947](#11947)) ([fc647eb](fc647eb)) * **avm:** Relation microbenchmarks ([#11974](#11974)) ([95b581d](95b581d)) * **cli:** Add `--target-dir` option (noir-lang/noir#7350) ([5efdd57](5efdd57)) * Indexed protocol contracts tree ([#11897](#11897)) ([96e84d4](96e84d4)) * **performance:** Check sub operations against induction variables (noir-lang/noir#7356) ([5efdd57](5efdd57)) * **performance:** Use unchecked ops based upon known induction variables (noir-lang/noir#7344) ([5efdd57](5efdd57)) * Small blob fixes/improvements ([#11686](#11686)) ([4eab9fc](4eab9fc)) * Update fee model ([#11953](#11953)) ([2798d58](2798d58)) * Use brillig optimized sha256 ([#11696](#11696)) ([438c905](438c905)) ### Bug Fixes * Ci fixes ([#11973](#11973)) ([6386f4e](6386f4e)) * **cli:** Only lock the packages selected in the workspace (noir-lang/noir#7345) ([5efdd57](5efdd57)) * Deterministic generation of vkeys in ts ([#11951](#11951)) ([7901cac](7901cac)) * Incorrect secondary file in LSP errors (noir-lang/noir#7347) ([5efdd57](5efdd57)) * Lock git dependencies folder when resolving workspace (noir-lang/noir#7327) ([5efdd57](5efdd57)) * Perform SSA constraints check on final SSA (noir-lang/noir#7334) ([5efdd57](5efdd57)) * Remove deprecated artifacts ([#11979](#11979)) ([4f0dce7](4f0dce7)) * Remove serial queue in broker facade ([#11956](#11956)) ([3485b52](3485b52)) * **ssa:** Make the lookback feature opt-in (noir-lang/noir#7190) ([5efdd57](5efdd57)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](#11972)) ([b865ccc](b865ccc)) * Avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) ([5efdd57](5efdd57)) * Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) ([5efdd57](5efdd57)) * Bump devnet boot node resources ([#11958](#11958)) ([bbcdefc](bbcdefc)) * **ci:** Add Vecs and vecs to cspell (noir-lang/noir#7342) ([5efdd57](5efdd57)) * Deprecate keccak256 (noir-lang/noir#7361) ([5efdd57](5efdd57)) * Fix warnings (noir-lang/noir#7330) ([5efdd57](5efdd57)) * Mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) ([5efdd57](5efdd57)) * Moving storage slot out of `NoteHeader` ([#11904](#11904)) ([8c4bb1c](8c4bb1c)) * Normalize path displayed by `nargo new` (noir-lang/noir#7328) ([5efdd57](5efdd57)) * Redo typo PR by osrm (noir-lang/noir#7238) ([5efdd57](5efdd57)) * Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) ([5efdd57](5efdd57)) * Remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) ([5efdd57](5efdd57)) * Remove misleading output from `nargo check` (noir-lang/noir#7329) ([5efdd57](5efdd57)) * Remove some unused types and functions in the AST (noir-lang/noir#7339) ([5efdd57](5efdd57)) * Remove unnecessary constants (noir-lang/noir#7326) ([5efdd57](5efdd57)) * Revive browser test before killing it ([#11964](#11964)) ([cb47cc0](cb47cc0)) * Split acirgen into multiple modules (noir-lang/noir#7310) ([5efdd57](5efdd57)) * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> <details><summary>barretenberg: 0.76.4</summary> ## [0.76.4](barretenberg-v0.76.3...barretenberg-v0.76.4) (2025-02-13) ### Features * Aes decryption oracle ([#11907](#11907)) ([c4ce913](c4ce913)) * **avm:** Constrained ec_add ([#11525](#11525)) ([f8fe602](f8fe602)) * **avm:** Interaction testing ([#11947](#11947)) ([fc647eb](fc647eb)) * **avm:** Relation microbenchmarks ([#11974](#11974)) ([95b581d](95b581d)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](#11972)) ([b865ccc](b865ccc)) * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@aztec-package-v0.76.3...aztec-package-v0.76.4) (2025-02-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@barretenberg.js-v0.76.3...barretenberg.js-v0.76.4) (2025-02-13) ### Miscellaneous * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> <details><summary>aztec-packages: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@aztec-packages-v0.76.3...aztec-packages-v0.76.4) (2025-02-13) ### Features * `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Aes decryption oracle ([#11907](AztecProtocol/aztec-packages#11907)) ([c4ce913](AztecProtocol/aztec-packages@c4ce913)) * **avm:** Constrained ec_add ([#11525](AztecProtocol/aztec-packages#11525)) ([f8fe602](AztecProtocol/aztec-packages@f8fe602)) * **avm:** Interaction testing ([#11947](AztecProtocol/aztec-packages#11947)) ([fc647eb](AztecProtocol/aztec-packages@fc647eb)) * **avm:** Relation microbenchmarks ([#11974](AztecProtocol/aztec-packages#11974)) ([95b581d](AztecProtocol/aztec-packages@95b581d)) * **cli:** Add `--target-dir` option (noir-lang/noir#7350) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Indexed protocol contracts tree ([#11897](AztecProtocol/aztec-packages#11897)) ([96e84d4](AztecProtocol/aztec-packages@96e84d4)) * **performance:** Check sub operations against induction variables (noir-lang/noir#7356) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * **performance:** Use unchecked ops based upon known induction variables (noir-lang/noir#7344) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Small blob fixes/improvements ([#11686](AztecProtocol/aztec-packages#11686)) ([4eab9fc](AztecProtocol/aztec-packages@4eab9fc)) * Update fee model ([#11953](AztecProtocol/aztec-packages#11953)) ([2798d58](AztecProtocol/aztec-packages@2798d58)) * Use brillig optimized sha256 ([#11696](AztecProtocol/aztec-packages#11696)) ([438c905](AztecProtocol/aztec-packages@438c905)) ### Bug Fixes * Ci fixes ([#11973](AztecProtocol/aztec-packages#11973)) ([6386f4e](AztecProtocol/aztec-packages@6386f4e)) * **cli:** Only lock the packages selected in the workspace (noir-lang/noir#7345) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Deterministic generation of vkeys in ts ([#11951](AztecProtocol/aztec-packages#11951)) ([7901cac](AztecProtocol/aztec-packages@7901cac)) * Incorrect secondary file in LSP errors (noir-lang/noir#7347) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Lock git dependencies folder when resolving workspace (noir-lang/noir#7327) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Perform SSA constraints check on final SSA (noir-lang/noir#7334) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove deprecated artifacts ([#11979](AztecProtocol/aztec-packages#11979)) ([4f0dce7](AztecProtocol/aztec-packages@4f0dce7)) * Remove serial queue in broker facade ([#11956](AztecProtocol/aztec-packages#11956)) ([3485b52](AztecProtocol/aztec-packages@3485b52)) * **ssa:** Make the lookback feature opt-in (noir-lang/noir#7190) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](AztecProtocol/aztec-packages#11972)) ([b865ccc](AztecProtocol/aztec-packages@b865ccc)) * Avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Bump devnet boot node resources ([#11958](AztecProtocol/aztec-packages#11958)) ([bbcdefc](AztecProtocol/aztec-packages@bbcdefc)) * **ci:** Add Vecs and vecs to cspell (noir-lang/noir#7342) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Deprecate keccak256 (noir-lang/noir#7361) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Fix warnings (noir-lang/noir#7330) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Moving storage slot out of `NoteHeader` ([#11904](AztecProtocol/aztec-packages#11904)) ([8c4bb1c](AztecProtocol/aztec-packages@8c4bb1c)) * Normalize path displayed by `nargo new` (noir-lang/noir#7328) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Redo typo PR by osrm (noir-lang/noir#7238) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove misleading output from `nargo check` (noir-lang/noir#7329) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove some unused types and functions in the AST (noir-lang/noir#7339) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove unnecessary constants (noir-lang/noir#7326) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Revive browser test before killing it ([#11964](AztecProtocol/aztec-packages#11964)) ([cb47cc0](AztecProtocol/aztec-packages@cb47cc0)) * Split acirgen into multiple modules (noir-lang/noir#7310) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> <details><summary>barretenberg: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@barretenberg-v0.76.3...barretenberg-v0.76.4) (2025-02-13) ### Features * Aes decryption oracle ([#11907](AztecProtocol/aztec-packages#11907)) ([c4ce913](AztecProtocol/aztec-packages@c4ce913)) * **avm:** Constrained ec_add ([#11525](AztecProtocol/aztec-packages#11525)) ([f8fe602](AztecProtocol/aztec-packages@f8fe602)) * **avm:** Interaction testing ([#11947](AztecProtocol/aztec-packages#11947)) ([fc647eb](AztecProtocol/aztec-packages@fc647eb)) * **avm:** Relation microbenchmarks ([#11974](AztecProtocol/aztec-packages#11974)) ([95b581d](AztecProtocol/aztec-packages@95b581d)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](AztecProtocol/aztec-packages#11972)) ([b865ccc](AztecProtocol/aztec-packages@b865ccc)) * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fcarreiro requested review from jeanmon, IlyasRidhuan and Maddiaa0 as code owners February 12, 2025 16:16

fcarreiro commented Feb 12, 2025

View reviewed changes

fcarreiro force-pushed the fc/avm-test-interactions branch from ddbcf23 to 95d3190 Compare February 12, 2025 16:19

fcarreiro commented Feb 12, 2025

View reviewed changes

fcarreiro force-pushed the fc/avm-test-interactions branch 2 times, most recently from e4dca6b to 554844d Compare February 12, 2025 16:43

dbanks12 reviewed Feb 12, 2025

View reviewed changes

fcarreiro force-pushed the fc/avm-test-interactions branch from 554844d to 24bd945 Compare February 12, 2025 17:42

IlyasRidhuan approved these changes Feb 13, 2025

View reviewed changes

fcarreiro mentioned this pull request Feb 13, 2025

chore(avm): tracegen interactions assertion #11972

Merged

jeanmon reviewed Feb 13, 2025

View reviewed changes

jeanmon approved these changes Feb 13, 2025

View reviewed changes

interaction testing

b1c51ff

fcarreiro force-pushed the fc/avm-test-interactions branch from 24bd945 to b1c51ff Compare February 13, 2025 10:51

fcarreiro mentioned this pull request Feb 13, 2025

feat(avm): relation microbenchmarks #11974

Merged

fcarreiro merged commit fc647eb into master Feb 13, 2025
53 of 54 checks passed

fcarreiro deleted the fc/avm-test-interactions branch February 13, 2025 12:05

AztecBot mentioned this pull request Feb 13, 2025

chore(master): Release 0.76.4 #11971

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): interaction testing #11947

feat(avm): interaction testing #11947

fcarreiro commented Feb 12, 2025 •

edited

Loading

fcarreiro commented Feb 12, 2025 •

edited

Loading

fcarreiro Feb 12, 2025

fcarreiro Feb 12, 2025

fcarreiro Feb 12, 2025

fcarreiro Feb 12, 2025

fcarreiro Feb 12, 2025

dbanks12 Feb 12, 2025

fcarreiro Feb 12, 2025

dbanks12 left a comment

dbanks12 Feb 12, 2025

fcarreiro Feb 12, 2025

dbanks12 Feb 12, 2025

fcarreiro Feb 12, 2025

dbanks12 Feb 12, 2025

dbanks12 Feb 12, 2025 •

edited

Loading

fcarreiro Feb 12, 2025

dbanks12 Feb 12, 2025

fcarreiro Feb 12, 2025

dbanks12 Feb 12, 2025

fcarreiro Feb 12, 2025

fcarreiro Feb 12, 2025

IlyasRidhuan left a comment

jeanmon Feb 13, 2025

fcarreiro Feb 13, 2025

jeanmon Feb 13, 2025

fcarreiro Feb 13, 2025

jeanmon left a comment

fcarreiro commented Feb 13, 2025

		@@ -0,0 +1,93 @@
		#include "barretenberg/vm2/constraining/polynomials.hpp"


		namespace bb::avm2::constraining {

		// Computes the polynomials from the trace, and destroys it in the process.

feat(avm): interaction testing #11947

feat(avm): interaction testing #11947

Conversation

fcarreiro commented Feb 12, 2025 • edited Loading

fcarreiro commented Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbanks12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbanks12 Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IlyasRidhuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeanmon left a comment

Choose a reason for hiding this comment

fcarreiro commented Feb 13, 2025

Merge activity

fcarreiro commented Feb 12, 2025 •

edited

Loading

fcarreiro commented Feb 12, 2025 •

edited

Loading

dbanks12 Feb 12, 2025 •

edited

Loading