feat: gen public base prover.toml #11757
Merged
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@MirandaWood Do you mind adding the command just before the noir constant AVM_PROOF_LENGTH_IN_FIELDS: |
jeanmon
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi AVM team - not sure if this is still helpful for you...
To avoid you having to run a long e2e test and update a load of irrelevant files when you need to change the
Prover.tomls, I added a small test inprover-client. This only updates public base.Just run:
from
yarn-project. On my side, it takes around 6 seconds.LMK if this is still useful, and if so where I can update docs so the command is easily found!