Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle sequencer building block mid-synch #11735

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Feb 4, 2025

This PR fixes a race condition in the sequencer that would happen in e2e tests (or sandbox, basically anywhere we warp time because of auto mine) where the sequencer would not handle a block being synchronized in the middle of block production.

This PR merges getting the chain tip with checking if its components are synchronized. This way it at least will fail at canProposeAtTime since the provided archive might be old.

Thanks @spalladino and @LHerskind for help debugging this one :)

@alexghr alexghr marked this pull request as draft February 5, 2025 08:37
@alexghr alexghr marked this pull request as ready for review February 5, 2025 09:49
@alexghr alexghr force-pushed the ag/race-in-seq-synch branch from 00905c5 to 8a3ec06 Compare February 5, 2025 09:53
@alexghr alexghr force-pushed the ag/race-in-seq-synch branch from 8a3ec06 to ac43e51 Compare February 5, 2025 10:13
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Changes to public function bytecode sizes

Generated at commit: ca38846cd95def1cdfeed03c7f539f4838fbade8, compared to commit: 2fd08babea610f97d63adcea5630cfd3065fd3a8

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch -4 ✅ -0.01%
AvmTest::bulk_testing -4 ✅ -0.02%
TokenBridge::public_dispatch -4 ✅ -0.02%
Test::consume_message_from_arbitrary_sender_public -4 ✅ -0.05%
AppSubscription::public_dispatch -4 ✅ -0.10%
AppSubscription::constructor -4 ✅ -0.13%
AvmTest::variable_base_msm -16 ✅ -6.96%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch 69,677 (-4) -0.01%
AvmTest::bulk_testing 22,134 (-4) -0.02%
TokenBridge::public_dispatch 21,090 (-4) -0.02%
Test::consume_message_from_arbitrary_sender_public 7,776 (-4) -0.05%
AppSubscription::public_dispatch 4,206 (-4) -0.10%
AppSubscription::constructor 3,062 (-4) -0.13%
AvmTest::variable_base_msm 214 (-16) -6.96%

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Changes to circuit sizes

Generated at commit: ca38846cd95def1cdfeed03c7f539f4838fbade8, compared to commit: 2fd08babea610f97d63adcea5630cfd3065fd3a8

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private +20 ❌ +0.01% +19 ❌ +0.00%
rollup_base_public +20 ❌ +0.01% +20 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 137,856 (+20) +0.01% 1,775,166 (+19) +0.00%
rollup_base_public 357,075 (+20) +0.01% 3,167,366 (+20) +0.00%

@alexghr alexghr enabled auto-merge (squash) February 5, 2025 16:41
@alexghr alexghr merged commit 435a0af into master Feb 5, 2025
52 checks passed
@alexghr alexghr deleted the ag/race-in-seq-synch branch February 5, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants