Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enforce fees #11480

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

feat!: enforce fees #11480

wants to merge 35 commits into from

Conversation

LeilaWang
Copy link
Collaborator

Please read contributing guidelines and remove this line.

@LeilaWang LeilaWang added the e2e-all CI: Enables this CI job. label Jan 24, 2025
@LeilaWang LeilaWang requested a review from dbanks12 as a code owner January 31, 2025 15:53
@AztecBot
Copy link
Collaborator

AztecBot commented Feb 8, 2025

Docs Preview

Hey there! 👋 You can check your preview at https://67ab14c2e5e6df7220d1e4ac--aztec-docs-dev.netlify.app

Copy link
Collaborator

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -63,12 +63,17 @@ impl PreviousKernelValidator {
}

fn validate_common(self) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename validate_common to validate_tail_common, it's a bit confusing!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@@ -32,6 +32,8 @@ export type SendMethodOptions = {
export abstract class BaseContractInteraction {
protected log = createLogger('aztecjs:contract_interaction');

private capsules: Fr[][] = [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Changes to circuit sizes

Generated at commit: 3795c8ea389621df99b7c82790d64809a0b7d413, compared to commit: 99fdab9dcf39d25462aa26b5fd9adad5c09586f8

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail +2 ❌ +0.05% 0 ➖ 0.00%
private_kernel_tail_to_public +2 ❌ +0.02% 0 ➖ 0.00%
rollup_base_private -11 ✅ -0.01% -11 ✅ -0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail 4,402 (+2) +0.05% 26,407 (0) 0.00%
private_kernel_tail_to_public 12,447 (+2) +0.02% 37,942 (0) 0.00%
rollup_base_private 137,825 (-11) -0.01% 1,637,938 (-11) -0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants