Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXE: Add NoteProcessor #8771

Closed
benesjan opened this issue Sep 25, 2024 · 1 comment · Fixed by #11414
Closed

TXE: Add NoteProcessor #8771

benesjan opened this issue Sep 25, 2024 · 1 comment · Fixed by #11414
Assignees
@nventuro
Labels
team-fairies Nico's team

Comments

@benesjan
Copy link
Contributor

benesjan commented Sep 25, 2024 •
edited
Loading

Currently in TXE notes are delivered via the notify_created_note_oracle. This unfortunately does not work for partial notes as there notify_created_note_oracle is not called (and cannot be called because we don't ever have the full note).

For this reason we will most likely need to spin up a full NoteProcessor in TXE.

Look for "TODO(#8771)" in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 25, 2024
@nventuro nventuro self-assigned this Sep 25, 2024
@benesjan benesjan changed the title Add NoteProcessor to TXE TXE: Add NoteProcessor Sep 26, 2024
@benesjan benesjan mentioned this issue Oct 31, 2024
Merged
@benesjan benesjan mentioned this issue Jan 16, 2025
Closed
@benesjan benesjan added the team-fairies Nico's team label Jan 21, 2025
@sklppy88 sklppy88 mentioned this issue Jan 23, 2025
Merged
@sklppy88
Copy link
Contributor

Closed as completed fully by #11414

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nventuro nventuro

Labels
team-fairies Nico's team
Projects
A3
Archived in project
Milestone
No milestone
3 participants
@nventuro @benesjan @sklppy88