Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decryption of TaggedNote not depend on "field overflow" #7053

Closed
Tracked by #5606
benesjan opened this issue Jun 14, 2024 · 0 comments · Fixed by #7066
Closed
Tracked by #5606

Make decryption of TaggedNote not depend on "field overflow" #7053

benesjan opened this issue Jun 14, 2024 · 0 comments · Fixed by #7066
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Jun 14, 2024

Right now we are heavily abusing that we will likely fail during bad decryption as some field will likely end up not fitting into Fr modulus. This is turning out to be problematic as we sometimes get false successful decryptions. Re-work it to use some other approach.

Better longer term approach is to fix the computation of note ids and then we can put the initialization vector into that field as well and use it as a mac. In that case, if the initialization vector matches then you have decrypted it correctly.

See this discussion for context.

Look for "TODO(#7053)" in the codebase.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 14, 2024
This was referenced Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant