Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(AztecMacro): Remove aes slice #6547

Closed
Tracked by #5077
Thunkar opened this issue May 21, 2024 · 0 comments · Fixed by #6550
Closed
Tracked by #5077

chore(AztecMacro): Remove aes slice #6547

Thunkar opened this issue May 21, 2024 · 0 comments · Fixed by #6550
Assignees
@Thunkar

Comments

@Thunkar
Copy link
Contributor

Thunkar commented May 21, 2024 •
edited
Loading

Noir stdlib now tries to avoid havin methods with an array and a slice versions. With some macro magic to determine note byte lengths, it should be possible to remove the aes128_encrypt_slice function and replace it with a generic array version.
@Thunkar Thunkar self-assigned this May 21, 2024
@Thunkar Thunkar added this to A3 May 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 May 21, 2024
This was referenced May 21, 2024
Open
Merged
Thunkar added a commit that referenced this issue May 22, 2024
@Thunkar @LHerskind
chore: remove aes slice (#6550)
f44d567 
Closes: #6547

Also generalises EncryptedLogBody so it can be used with things that
aren't notes

---------

Co-authored-by: LHerskind <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 22, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue May 23, 2024
@Thunkar @LHerskind @AztecBot
chore: remove aes slice (#6550)
821eafc 
Closes: AztecProtocol/aztec-packages#6547

Also generalises EncryptedLogBody so it can be used with things that
aren't notes

---------

Co-authored-by: LHerskind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunkar Thunkar

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove aes slice AztecProtocol/aztec-packages
1 participant
@Thunkar