Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Keys_Incoming): Use proper AES in the encrypted logs #6172

Closed
Tracked by #5606
LHerskind opened this issue May 3, 2024 · 0 comments · Fixed by #6269
Closed
Tracked by #5606

feat(Keys_Incoming): Use proper AES in the encrypted logs #6172

LHerskind opened this issue May 3, 2024 · 0 comments · Fixed by #6269
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

LHerskind commented May 3, 2024 •
edited
Loading

The current implementation of a encrypted log header is using the AES oracle. It should be replaced with the actual AES.

Same is the case for the body.

Search for "6172" in the repo.
@github-project-automation github-project-automation bot moved this to Todo in A3 May 3, 2024
@LHerskind LHerskind mentioned this issue May 3, 2024
Closed
@LHerskind LHerskind changed the title feat(Keys_Incoming): Use proper AES in the encrypted logs header feat(Keys_Incoming): Use proper AES in the encrypted logs May 7, 2024
@LHerskind LHerskind self-assigned this May 8, 2024
This was referenced May 8, 2024
Merged
Merged
LHerskind added a commit that referenced this issue May 9, 2024
@LHerskind @Thunkar
@dbanks12 @benesjan
feat: Proper padding in ts AES and constrained AES in body and header…
ef9cdde 
… computations (#6269)

Fixes #6172. 

Also fixes an issue as the typescript AES was not doing proper padding. 

Battling noir, good with help from @Thunkar.

---------

Co-authored-by: thunkar <[email protected]>
Co-authored-by: David Banks <[email protected]>
Co-authored-by: Jan Beneš <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@LHerskind