Skip to content

Commit

Permalink
chore: Fix logs upload to S3 (#6401)
Browse files Browse the repository at this point in the history
As e2es were moved to a remote runner, they no longer inherit the env
from github, so EARTHLY_BUILD_ARGS were not passed, so the target folder
for uploading logs was unset.
  • Loading branch information
spalladino authored May 15, 2024
1 parent 44d7916 commit 9df0602
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
set -eux
cd ./yarn-project/end-to-end/
export FORCE_COLOR=1
export EARTHLY_BUILD_ARGS="${{ env.EARTHLY_BUILD_ARGS }}"
../../scripts/earthly-ci -P \
--secret AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_KEY_ID }} \
--secret AWS_SECRET_ACCESS_KEY=${{ secrets.AWS_SECRET_ACCESS_KEY }} \
Expand Down

0 comments on commit 9df0602

Please sign in to comment.