Addressing review comments

AztecProtocol · Jun 18, 2024 · 885ff8a · 885ff8a
1 parent 1ccbe1a
commit 885ff8a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/barretenberg/cpp/Earthfile b/barretenberg/cpp/Earthfile
@@ -262,7 +262,7 @@ vm-full-test:
     IF [ "$HARDWARE_CONCURRENCY" != "" ]
         ENV HARDWARE_CONCURRENCY=$hardware_concurrency
     END
-    RUN cd build && GTEST_COLOR=1 AVM_TESTS_ENABLE_PROVING=1 ctest -j4 --test-dir src/barretenberg/vm --output-on-failure
+    RUN cd build && GTEST_COLOR=1 AVM_ENABLE_FULL_PROVING=1 ctest -j4 --test-dir src/barretenberg/vm --output-on-failure
 
 build:
     BUILD +preset-wasm

diff --git a/barretenberg/cpp/src/barretenberg/vm/avm_trace/avm_common.hpp b/barretenberg/cpp/src/barretenberg/vm/avm_trace/avm_common.hpp
@@ -15,8 +15,8 @@ namespace bb::avm_trace {
 using Flavor = bb::AvmFlavor;
 using FF = Flavor::FF;
 
-// To toggle all relevant unit tests with proving, set the env variable "AVM_TESTS_ENABLE_PROVING".
-static const bool ENABLE_PROVING = std::getenv("AVM_TESTS_ENABLE_PROVING") != nullptr;
+// To toggle all relevant unit tests with proving, set the env variable "AVM_ENABLE_FULL_PROVING".
+static const bool ENABLE_PROVING = std::getenv("AVM_ENABLE_FULL_PROVING") != nullptr;
 
 // There are 4 public input columns, 1 for context inputs, and 3 for emitting side effects
 using VmPublicInputs = std::tuple<std::array<FF, KERNEL_INPUTS_LENGTH>,   // Input: Kernel context inputs

diff --git a/yarn-project/end-to-end/src/e2e_prover/full.test.ts b/yarn-project/end-to-end/src/e2e_prover/full.test.ts
@@ -7,6 +7,8 @@ const TIMEOUT = 1_800_000;
 
 // This makes AVM proving throw if there's a failure.
 process.env.AVM_PROVING_STRICT = '1';
+// Enable proving the full lookup tables (no truncation).
+process.env.AVM_ENABLE_FULL_PROVING = '1';
 
 describe('full_prover', () => {
   const t = new FullProverTest('full_prover', 2);