refactor: Move transcripts (#3176)

As a a first step toward breaking up the barretenberg/honk submodule,
which is gotten very large, I move the Honk transcript out of Honk. This
will enable moving ZeroMorph and other hings in barretenberg/honk/pcs
out of honk. it is now in barretenberg/transcript. Formerly
barretenberg/transcript was the Plonk transcript. This goes into
barretenberg/plonk.

barretenberg/cpp/src/CMakeLists.txt

@@ -48,26 +48,26 @@ else()
     message(STATUS "Using optimized assembly for field arithmetic.")
 endif()
 
-add_subdirectory(barretenberg/env)
+add_subdirectory(barretenberg/bb)
 add_subdirectory(barretenberg/common)
-add_subdirectory(barretenberg/numeric)
-add_subdirectory(barretenberg/srs)
-add_subdirectory(barretenberg/ecc)
 add_subdirectory(barretenberg/crypto)
-add_subdirectory(barretenberg/polynomials)
-add_subdirectory(barretenberg/proof_system)
-add_subdirectory(barretenberg/transcript)
-add_subdirectory(barretenberg/honk)
-add_subdirectory(barretenberg/plonk)
-add_subdirectory(barretenberg/stdlib)
-add_subdirectory(barretenberg/join_split_example)
 add_subdirectory(barretenberg/dsl)
+add_subdirectory(barretenberg/ecc)
+add_subdirectory(barretenberg/env)
 add_subdirectory(barretenberg/examples)
+add_subdirectory(barretenberg/grumpkin_srs_gen)
+add_subdirectory(barretenberg/honk)
+add_subdirectory(barretenberg/join_split_example)
+add_subdirectory(barretenberg/numeric)
+add_subdirectory(barretenberg/plonk)
+add_subdirectory(barretenberg/polynomials)
+add_subdirectory(barretenberg/proof_system)
 add_subdirectory(barretenberg/serialize)
 add_subdirectory(barretenberg/solidity_helpers)
+add_subdirectory(barretenberg/srs)
+add_subdirectory(barretenberg/stdlib)
+add_subdirectory(barretenberg/transcript)
 add_subdirectory(barretenberg/wasi)
-add_subdirectory(barretenberg/grumpkin_srs_gen)
-add_subdirectory(barretenberg/bb)
 
 
 if(SMT)
@@ -89,7 +89,6 @@ message(STATUS "Compiling all-in-one barretenberg archive")
 add_library(
     barretenberg
     STATIC
-    $<TARGET_OBJECTS:dsl_objects>
     $<TARGET_OBJECTS:common_objects>
     $<TARGET_OBJECTS:crypto_aes128_objects>
     $<TARGET_OBJECTS:crypto_blake2s_objects>
@@ -100,6 +99,7 @@ add_library(
     $<TARGET_OBJECTS:crypto_pedersen_hash_objects>
     $<TARGET_OBJECTS:crypto_schnorr_objects>
     $<TARGET_OBJECTS:crypto_sha256_objects>
+    $<TARGET_OBJECTS:dsl_objects>
     $<TARGET_OBJECTS:ecc_objects>
     $<TARGET_OBJECTS:examples_objects>
     $<TARGET_OBJECTS:honk_objects>
@@ -134,8 +134,6 @@ if(WASM)
     # to implement the functions in env.
     add_executable(
         barretenberg.wasm
-        $<TARGET_OBJECTS:wasi_objects>
-        $<TARGET_OBJECTS:dsl_objects>
         $<TARGET_OBJECTS:common_objects>
         $<TARGET_OBJECTS:crypto_aes128_objects>
         $<TARGET_OBJECTS:crypto_blake2s_objects>
@@ -146,6 +144,7 @@ if(WASM)
         $<TARGET_OBJECTS:crypto_pedersen_hash_objects>
         $<TARGET_OBJECTS:crypto_schnorr_objects>
         $<TARGET_OBJECTS:crypto_sha256_objects>
+        $<TARGET_OBJECTS:dsl_objects>
         $<TARGET_OBJECTS:ecc_objects>
         $<TARGET_OBJECTS:examples_objects>
         $<TARGET_OBJECTS:honk_objects>
@@ -165,6 +164,7 @@ if(WASM)
         $<TARGET_OBJECTS:stdlib_schnorr_objects>
         $<TARGET_OBJECTS:stdlib_sha256_objects>
         $<TARGET_OBJECTS:transcript_objects>
+        $<TARGET_OBJECTS:wasi_objects>
     )
 
     add_executable(

barretenberg/cpp/src/barretenberg/barretenberg.hpp

@@ -47,6 +47,7 @@
 #include "stdlib/merkle_tree/merkle_tree.hpp"
 // TODO(https://github.com/AztecProtocol/aztec-packages/issues/728):
 //     Consider moving nullifier tree logic out of barretenberg into aztec repo
+#include "barretenberg/plonk/transcript/manifest.hpp"
 #include "stdlib/merkle_tree/nullifier_tree/nullifier_leaf.hpp"
 #include "stdlib/merkle_tree/nullifier_tree/nullifier_memory_tree.hpp"
 #include "stdlib/merkle_tree/nullifier_tree/nullifier_tree.hpp"
@@ -68,4 +69,3 @@
 #include "stdlib/recursion/verification_key/verification_key.hpp"
 #include "stdlib/recursion/verifier/program_settings.hpp"
 #include "stdlib/recursion/verifier/verifier.hpp"
-#include "transcript/manifest.hpp"

barretenberg/cpp/src/barretenberg/dsl/acir_format/recursion_constraint.cpp

@@ -1,8 +1,8 @@
 #include "recursion_constraint.hpp"
 #include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp"
+#include "barretenberg/plonk/transcript/transcript_wrappers.hpp"
 #include "barretenberg/stdlib/recursion/aggregation_state/aggregation_state.hpp"
 #include "barretenberg/stdlib/recursion/verifier/verifier.hpp"
-#include "barretenberg/transcript/transcript_wrappers.hpp"
 
 namespace acir_format {
 

barretenberg/cpp/src/barretenberg/honk/composer/eccvm_composer.cpp

@@ -118,4 +118,4 @@ std::shared_ptr<typename Flavor::VerificationKey> ECCVMComposer_<Flavor>::comput
 template class ECCVMComposer_<honk::flavor::ECCVM>;
 template class ECCVMComposer_<honk::flavor::ECCVMGrumpkin>;
 
-} // namespace proof_system::honk
+} // namespace proof_system::honk

barretenberg/cpp/src/barretenberg/honk/transcript/eccvm_transcript.test.cpp → barretenberg/cpp/src/barretenberg/honk/composer/eccvm_transcript.test.cpp

@@ -3,7 +3,7 @@
 #include "barretenberg/numeric/bitop/get_msb.hpp"
 #include "barretenberg/polynomials/univariate.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
-#include "transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <gtest/gtest.h>
 
 using namespace proof_system::honk;

barretenberg/cpp/src/barretenberg/honk/transcript/goblin_ultra_transcript.test.cpp → barretenberg/cpp/src/barretenberg/honk/composer/goblin_ultra_transcript.test.cpp

@@ -3,14 +3,14 @@
 #include "barretenberg/numeric/bitop/get_msb.hpp"
 #include "barretenberg/polynomials/univariate.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
-#include "transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <gtest/gtest.h>
 
 using namespace proof_system::honk;
 
 class GoblinUltraTranscriptTests : public ::testing::Test {
   public:
-    static void SetUpTestSuite() { barretenberg::srs::init_crs_factory("../srs_db/ignition"); }
+    // static void SetUpTestSuite() { barretenberg::srs::init_crs_factory("../srs_db/ignition"); }
 
     using Flavor = proof_system::honk::flavor::GoblinUltra;
     using FF = Flavor::FF;

barretenberg/cpp/src/barretenberg/honk/composer/ultra_composer.hpp

@@ -8,12 +8,7 @@
 #include "barretenberg/honk/proof_system/ultra_verifier.hpp"
 #include "barretenberg/proof_system/composer/composer_lib.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
-#include "barretenberg/srs/factories/file_crs_factory.hpp"
-
-#include <cstddef>
-#include <memory>
-#include <utility>
-#include <vector>
+#include "barretenberg/srs/global_crs.hpp"
 
 namespace proof_system::honk {
 template <UltraFlavor Flavor> class UltraComposer_ {

barretenberg/cpp/src/barretenberg/honk/transcript/ultra_transcript.test.cpp → barretenberg/cpp/src/barretenberg/honk/composer/ultra_transcript.test.cpp

@@ -3,7 +3,7 @@
 #include "barretenberg/numeric/bitop/get_msb.hpp"
 #include "barretenberg/polynomials/univariate.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
-#include "transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <gtest/gtest.h>
 
 using namespace proof_system::honk;

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_ultra.hpp

@@ -1,6 +1,5 @@
 #pragma once
 #include "barretenberg/honk/pcs/kzg/kzg.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/univariate.hpp"
 #include "barretenberg/proof_system/circuit_builder/goblin_ultra_circuit_builder.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
@@ -11,6 +10,7 @@
 #include "barretenberg/proof_system/relations/lookup_relation.hpp"
 #include "barretenberg/proof_system/relations/permutation_relation.hpp"
 #include "barretenberg/proof_system/relations/ultra_arithmetic_relation.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk::flavor {
 

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_ultra_recursive.hpp

@@ -6,7 +6,6 @@
 #include "barretenberg/polynomials/univariate.hpp"
 
 #include "barretenberg/honk/flavor/goblin_ultra.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/evaluation_domain.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
 #include "barretenberg/proof_system/circuit_builder/goblin_ultra_circuit_builder.hpp"
@@ -19,6 +18,7 @@
 #include "barretenberg/proof_system/relations/permutation_relation.hpp"
 #include "barretenberg/proof_system/relations/ultra_arithmetic_relation.hpp"
 #include "barretenberg/srs/factories/crs_factory.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <array>
 #include <concepts>
 #include <span>

barretenberg/cpp/src/barretenberg/honk/flavor/ultra.hpp

@@ -1,7 +1,6 @@
 #pragma once
 #include "barretenberg/ecc/curves/bn254/g1.hpp"
 #include "barretenberg/honk/pcs/kzg/kzg.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/barycentric.hpp"
 #include "barretenberg/polynomials/evaluation_domain.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
@@ -14,6 +13,7 @@
 #include "barretenberg/proof_system/relations/lookup_relation.hpp"
 #include "barretenberg/proof_system/relations/permutation_relation.hpp"
 #include "barretenberg/proof_system/relations/ultra_arithmetic_relation.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk::flavor {
 

barretenberg/cpp/src/barretenberg/honk/flavor/ultra_recursive.hpp

@@ -6,7 +6,6 @@
 #include "barretenberg/polynomials/univariate.hpp"
 
 #include "barretenberg/honk/flavor/ultra.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/evaluation_domain.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
 #include "barretenberg/proof_system/circuit_builder/ultra_circuit_builder.hpp"
@@ -18,6 +17,7 @@
 #include "barretenberg/proof_system/relations/permutation_relation.hpp"
 #include "barretenberg/proof_system/relations/ultra_arithmetic_relation.hpp"
 #include "barretenberg/srs/factories/crs_factory.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 #include <array>
 #include <concepts>

barretenberg/cpp/src/barretenberg/honk/pcs/commitment_key.test.hpp

@@ -1,22 +1,17 @@
 #pragma once
 
-#include <cstddef>
-#include <gtest/gtest.h>
-
-#include <algorithm>
-#include <concepts>
-#include <memory>
-#include <string_view>
-
 #include "barretenberg/ecc/curves/bn254/g1.hpp"
 #include "barretenberg/honk/pcs/commitment_key.hpp"
 #include "barretenberg/honk/pcs/verification_key.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
 #include "barretenberg/srs/factories/file_crs_factory.hpp"
-
-#include "../../transcript/transcript_wrappers.hpp"
-
 #include "claim.hpp"
+#include <algorithm>
+#include <concepts>
+#include <memory>
+#include <string_view>
+
+#include <gtest/gtest.h>
 
 namespace proof_system::honk::pcs {
 

barretenberg/cpp/src/barretenberg/honk/pcs/gemini/gemini.hpp

@@ -1,8 +1,8 @@
 #pragma once
 
 #include "../claim.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 #include <vector>
 

barretenberg/cpp/src/barretenberg/honk/pcs/gemini/gemini.test.cpp

@@ -1,8 +1,8 @@
 #include "gemini.hpp"
 
 #include "../commitment_key.test.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <cstddef>
 #include <gtest/gtest.h>
 #include <span>

barretenberg/cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp

@@ -3,7 +3,7 @@
 #include "barretenberg/ecc/scalar_multiplication/scalar_multiplication.hpp"
 #include "barretenberg/honk/pcs/claim.hpp"
 #include "barretenberg/honk/pcs/verification_key.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 #include <cstddef>
 #include <numeric>
 #include <string>

barretenberg/cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp

@@ -3,8 +3,8 @@
 #include "../claim.hpp"
 #include "barretenberg/honk/pcs/commitment_key.hpp"
 #include "barretenberg/honk/pcs/verification_key.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/polynomials/polynomial.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 #include <memory>
 #include <utility>

barretenberg/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.hpp

@@ -2,7 +2,7 @@
 #include "barretenberg/honk/pcs/claim.hpp"
 #include "barretenberg/honk/pcs/commitment_key.hpp"
 #include "barretenberg/honk/pcs/verification_key.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 /**
  * @brief Reduces multiple claims about commitments, each opened at a single point

barretenberg/cpp/src/barretenberg/honk/pcs/zeromorph/zeromorph.test.cpp

@@ -1,6 +1,6 @@
 #include "zeromorph.hpp"
 #include "../commitment_key.test.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 #include <gtest/gtest.h>
 

barretenberg/cpp/src/barretenberg/honk/proof_system/eccvm_prover.cpp

@@ -9,7 +9,6 @@
 #include "barretenberg/polynomials/univariate.hpp" // will go away
 #include "barretenberg/proof_system/relations/lookup_relation.hpp"
 #include "barretenberg/proof_system/relations/permutation_relation.hpp"
-#include "barretenberg/transcript/transcript_wrappers.hpp"
 #include <algorithm>
 #include <array>
 #include <cstddef>

barretenberg/cpp/src/barretenberg/honk/proof_system/eccvm_prover.hpp

@@ -3,9 +3,9 @@
 #include "barretenberg/honk/pcs/gemini/gemini.hpp"
 #include "barretenberg/honk/pcs/shplonk/shplonk.hpp"
 #include "barretenberg/honk/sumcheck/sumcheck_output.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/plonk/proof_system/types/proof.hpp"
 #include "barretenberg/proof_system/relations/relation_parameters.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk {
 

barretenberg/cpp/src/barretenberg/honk/proof_system/eccvm_verifier.cpp

@@ -1,9 +1,9 @@
 #include "./eccvm_verifier.hpp"
 #include "barretenberg/honk/pcs/gemini/gemini.hpp"
 #include "barretenberg/honk/pcs/shplonk/shplonk.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/honk/utils/power_polynomial.hpp"
 #include "barretenberg/numeric/bitop/get_msb.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 using namespace barretenberg;
 using namespace proof_system::honk::sumcheck;

barretenberg/cpp/src/barretenberg/honk/proof_system/goblin_merge/merge_prover.hpp

@@ -3,9 +3,9 @@
 #include "barretenberg/honk/flavor/goblin_ultra.hpp"
 #include "barretenberg/honk/flavor/ultra.hpp"
 #include "barretenberg/honk/pcs/claim.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/plonk/proof_system/types/proof.hpp"
 #include "barretenberg/proof_system/op_queue/ecc_op_queue.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk {
 

barretenberg/cpp/src/barretenberg/honk/proof_system/goblin_merge/merge_verifier.hpp

@@ -3,9 +3,9 @@
 #include "barretenberg/honk/flavor/goblin_ultra.hpp"
 #include "barretenberg/honk/flavor/ultra.hpp"
 #include "barretenberg/honk/pcs/claim.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/plonk/proof_system/types/proof.hpp"
 #include "barretenberg/proof_system/op_queue/ecc_op_queue.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk {
 

barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_verifier.hpp

@@ -3,8 +3,8 @@
 #include "barretenberg/honk/flavor/ultra.hpp"
 #include "barretenberg/honk/instance/instances.hpp"
 #include "barretenberg/honk/proof_system/folding_result.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/proof_system/flavor/flavor.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk {
 template <class VerifierInstances> class ProtoGalaxyVerifier_ {

barretenberg/cpp/src/barretenberg/honk/proof_system/ultra_prover.hpp

@@ -4,9 +4,9 @@
 #include "barretenberg/honk/instance/prover_instance.hpp"
 #include "barretenberg/honk/pcs/zeromorph/zeromorph.hpp"
 #include "barretenberg/honk/sumcheck/sumcheck_output.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/plonk/proof_system/types/proof.hpp"
 #include "barretenberg/proof_system/relations/relation_parameters.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 namespace proof_system::honk {
 

barretenberg/cpp/src/barretenberg/honk/proof_system/ultra_verifier.cpp

@@ -1,8 +1,8 @@
 #include "./ultra_verifier.hpp"
 #include "barretenberg/honk/pcs/zeromorph/zeromorph.hpp"
-#include "barretenberg/honk/transcript/transcript.hpp"
 #include "barretenberg/honk/utils/power_polynomial.hpp"
 #include "barretenberg/numeric/bitop/get_msb.hpp"
+#include "barretenberg/transcript/transcript.hpp"
 
 using namespace barretenberg;
 using namespace proof_system::honk::sumcheck;