Skip to content

Commit

Permalink
Fix serialization
Browse files Browse the repository at this point in the history
  • Loading branch information
spalladino committed Jan 25, 2024
1 parent e773128 commit 540b220
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion yarn-project/pxe/src/database/kv_pxe_database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export class KVPxeDatabase implements PxeDatabase {

getContractArtifact(id: Fr): Promise<ContractArtifact | undefined> {
const contract = this.#contractArtifacts.get(id.toString());
return Promise.resolve(contract && contractArtifactFromBuffer(contract));
// TODO(@spalladino): AztecMap lies and returns Uint8Arrays instead of Buffers, hence the extra Buffer.from.
return Promise.resolve(contract && contractArtifactFromBuffer(Buffer.from(contract)));
}

async addContractInstance(contract: ContractInstanceWithAddress): Promise<void> {
Expand Down
4 changes: 2 additions & 2 deletions yarn-project/types/src/abi/contract_artifact.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { mockVerificationKey } from './mocked_keys.js';
*/
export function contractArtifactToBuffer(artifact: ContractArtifact): Buffer {
// TODO(@spalladino): More efficient serialization
return Buffer.from(JSON.stringify(artifact));
return Buffer.from(JSON.stringify(artifact), 'utf8');
}

/**
Expand All @@ -27,7 +27,7 @@ export function contractArtifactToBuffer(artifact: ContractArtifact): Buffer {
*/
export function contractArtifactFromBuffer(buffer: Buffer): ContractArtifact {
// TODO(@spalladino): More efficient serialization
return JSON.parse(buffer.toString()) as ContractArtifact;
return JSON.parse(buffer.toString('utf8')) as ContractArtifact;
}

/**
Expand Down

0 comments on commit 540b220

Please sign in to comment.