Skip to content

Commit

Permalink
fix: hackily fix the public input columns of avm recursion constraint (
Browse files Browse the repository at this point in the history
…#11428)

Currently, this test triggers a builder failure. The hack sets some of
the public input columns of the recursive verifier to be all 0
witnesses. Add TODO for fixing it properly later.

Discovered when experimenting during
#11205.
  • Loading branch information
lucasxia01 authored Jan 22, 2025
1 parent 01510f4 commit 436c3c6
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ template <typename FF_> VmPublicInputs_<FF_> convert_public_inputs(std::vector<F
ko_side_effect[dest_offset] = public_inputs_vec[pcpi_offset + 1];
ko_metadata[dest_offset] = public_inputs_vec[pcpi_offset + 2];
}
// TODO(#11426): Fix public input columns.
if constexpr (!std::same_as<FF_, field<Bn254FrParams>>) {
auto ctx = public_inputs_vec[0].get_context();
for (size_t i = 0; i < KERNEL_OUTPUTS_LENGTH; i++) {
ko_values[i] = FF_::from_witness(ctx, 0);
ko_side_effect[i] = FF_::from_witness(ctx, 0);
ko_metadata[i] = FF_::from_witness(ctx, 0);
}
}

return public_inputs;
}
Expand Down

1 comment on commit 436c3c6

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 436c3c6 Previous: 01510f4 Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20 4463.859380999992 ms/iter 4046.244662000021 ms/iter 1.10
wasmClientIVCBench/Full/6 82485.749544 ms/iter 77198.532948 ms/iter 1.07
commit(t) 3467897005 ns/iter 3210977855 ns/iter 1.08
Goblin::merge(t) 146839577 ns/iter 132574195 ns/iter 1.11

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.