Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second TroveBridge audit feedback #284

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Second TroveBridge audit feedback #284

merged 5 commits into from
Nov 21, 2022

Conversation

benesjan
Copy link
Collaborator

@benesjan benesjan commented Nov 18, 2022 •
edited
Loading

Description

Implementation of changes based on second TroveBridge audit feedback.

Changes

  1. Fixed the underflow bug,
  2. improved naming as recommended in the audit report,
  3. fixed "overshadow" bug found by a test.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@benesjan benesjan force-pushed the janb/second-trove-audit-feedback branch from 5af044a to 732c0e6 Compare November 18, 2022 19:28
@benesjan benesjan requested a review from LHerskind November 18, 2022 20:46
@benesjan benesjan force-pushed the janb/second-trove-audit-feedback branch from afda773 to b24f181 Compare November 21, 2022 15:17
@benesjan benesjan force-pushed the janb/second-trove-audit-feedback branch from b24f181 to ad5a824 Compare November 21, 2022 15:26
LHerskind
LHerskind approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the overshadowing. Thanks for adding the extra test.

@benesjan benesjan merged commit c2b4904 into master Nov 21, 2022
@benesjan benesjan deleted the janb/second-trove-audit-feedback branch December 1, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @LHerskind