Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade element bridge to use falafel's new REST API #272

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Nov 3, 2022

Description

This PR is adding new APIs that will replace graphQL functionality.
Updating logic here to use new APIs. Once this is merged & released, we can remove graphQL altogether from falafel

Setting this as "draft" until new Falafel APIs are released

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@spypsy spypsy marked this pull request as draft November 7, 2022 18:59
@spypsy spypsy marked this pull request as ready for review November 21, 2022 10:15
@benesjan
Copy link
Collaborator

benesjan commented Nov 21, 2022

@spypsy I just merged my PR which makes the contract tests pass. Please rebase on master. It will hopefully make the whole CI pass.

@benesjan benesjan merged commit e6cf987 into master Nov 21, 2022
@benesjan benesjan deleted the sp/update_element branch November 21, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants