Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch address from status endpoint for dev and testnets #233

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Fetch address from status endpoint for dev and testnets #233

merged 4 commits into from
Sep 9, 2022

Conversation

LHerskind
Copy link
Collaborator

@LHerskind LHerskind commented Sep 9, 2022 •
edited
Loading

Description

Replaces the hardcoded addresses in the BaseDeployment.s.sol script to use the FFI cheatcode to fetch latest rollup processor addresses for the dev- and testnets. Deployment scripts need to use --ffi to get this properly.

Also using createSelectFork to simplify deployments

Quality of life improvement.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@LHerskind LHerskind added the enhancement New feature or request label Sep 9, 2022
benesjan
benesjan approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so clean. Good idea fetching the addresses directly from Falafel 👍

@LHerskind LHerskind marked this pull request as ready for review September 9, 2022 12:21
@LHerskind LHerskind merged commit aa6ac80 into master Sep 9, 2022
@LHerskind LHerskind deleted the lh/base-deployment-addresses branch December 8, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LHerskind @benesjan