Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lh/yearn rollup processor arg #215

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

LHerskind
Copy link
Collaborator

Description

The yearn client data is using a constant address rollup processor, which makes it a little impractical for testnet deployments. This PR updates such that an address is passed to the create instead.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@LHerskind LHerskind marked this pull request as ready for review August 23, 2022 10:22
@LHerskind LHerskind force-pushed the lh/yearn-rollup-processor-arg branch from 6377c93 to f0256c5 Compare August 23, 2022 10:30
@LHerskind LHerskind merged commit ee38a7b into master Aug 23, 2022
@LHerskind LHerskind deleted the lh/yearn-rollup-processor-arg branch December 8, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants