Stop dockerd nicely #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Stop dockerd by sending SIGTERM and if it fails to terminate, send SIGKILL after 20 seconds. When all containers stop quickly, dockerd will stop in just 1 second. If one or more containers refuse to stop, dockerd will send SIGKILL after 10 seconds, meaning dockerd will take 11 or 12 seconds to stop. The old behavior was to always wait 10 seconds, then send SIGTERM, but the intention was the behavior described above, save for a too short SIGKILL delay.
killenheladagen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of d7a2fdbd3a261e7e7880fd418f698ebf46df5a0a
The original PR was #185 with message:
Stop dockerd by sending SIGTERM and if it fails to terminate, send SIGKILL after 20 seconds.
When all containers stop quickly, dockerd will stop in just 1 second. If one or more containers refuse to stop, dockerd will send SIGKILL after 10 seconds, meaning dockerd will take 11 or 12 seconds to stop.
The old behavior was to always wait 10 seconds, then send SIGTERM, but the intention was the behavior described above, save for a too short SIGKILL delay.
Checklist before requesting a review