Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log more details around child process start and stop #94

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2024

This is an automatic cherry-pick of f122725cca4f4db138f4e78e52932b5094185fcf

The original PR was #182 with message:

By logging the PID, it's easier to tell sessions apart.

The log level has been reduced to log_debug,
since there are log_info messages that better convey the state transitions in the applications.

Exit code and signal number are no longer mixed up in the log. The new log messages look like this:

  • killall -SIGINT dockerd → "exited with exit code 0"
  • killall -SIGTERM dockerd → "exited with exit code 0"
  • killall -SIGABRT dockerd → "exited with exit code 2"
  • killall -SIGKILL dockerd → "was killed by signal 9"

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

By logging the PID, it's easier to tell sessions apart.

The log level has been reduced to log_debug,
since there are log_info messages that better convey the state transitions in the applications.

Exit code and signal number are no longer mixed up in the log.
The new log messages look like this:

* killall -SIGINT  dockerd → "exited with exit code 0"
* killall -SIGTERM dockerd → "exited with exit code 0"
* killall -SIGABRT dockerd → "exited with exit code 2"
* killall -SIGKILL dockerd → "was killed by signal 9"
@github-actions github-actions bot requested a review from a team as a code owner April 9, 2024 12:33
@killenheladagen killenheladagen merged commit e9e21a9 into main Apr 9, 2024
@killenheladagen killenheladagen deleted the cherrybot-23851 branch April 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant