Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deadlock when acting on parameter changes #87

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 8, 2024

This is an automatic cherry-pick of dab9c5f1714afb45f022751584c18ba28cb88ae1

The original PR was #176 with message:

When there are multiple AXParameter callbacks in a queue, such as during the first parameter change after installation, any parameter usage, even outside a callback, will cause a 20 second deadlock per queued callback.

The workaround is to delay the call back to g_main_loop_quit() by 1 second using a timer callback.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@github-actions github-actions bot requested a review from a team as a code owner April 8, 2024 08:20
@killenheladagen killenheladagen merged commit cf12ea1 into main Apr 8, 2024
@killenheladagen killenheladagen deleted the cherrybot-24034 branch April 8, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant