Refactor order of parameter check #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* rebased * Change from syslog(LOG_ERR, ...) to log_error(...) --------- Co-authored-by: madelen-at-work <[email protected]> Co-authored-by: Mattias Axelsson <[email protected]>
madelen-at-work
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of 7a595cede22d7aba853d9ff590859eb1d6bd0503
The original PR was #173 with message:
Describe your changes
If TCP socket is not selected we do not need to verify the TLS certs, even if Use TLS is selected. When the user changes the TCP socket setting we will revisit (and do) the check.
Checklist before requesting a review