Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters as bool instead of enums #82

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 5, 2024

This is an automatic cherry-pick of 03f871eee3414b6c9fc2d73743c463c3bedb58bf

The original PR was #169 with message:

Describe your changes

All current parameters are treated as bools so we might as well use the bool type

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Co-authored-by: madelen-at-work <[email protected]>
@github-actions github-actions bot requested a review from a team as a code owner April 5, 2024 14:07
fix conflict
@madelen-at-work madelen-at-work changed the title CHERRY-PICK CONFLICT Parameters as bool instead of enums Parameters as bool instead of enums Apr 5, 2024
@madelen-at-work madelen-at-work merged commit cff2866 into main Apr 5, 2024
9 of 10 checks passed
@madelen-at-work madelen-at-work deleted the cherrybot-11487 branch April 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant