Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootless implementation #53

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented Nov 2, 2023

Describe your changes

Brings in same changes as Docker ACAP PR 107
NOTE! Known issues

  • Only uid and gid are properly mapped between device and containers, not the other groups that the user is a member of. This means that resources on the device, even if they are volume or device mounted can be inaccesible inisde the container. This can also affect usage of unsuported dbus methods from the container
  • iptables use is disabled
  • The docker.socket group ownership is set to addon - ideally we would want to change this to e.g. sdk
  • Symlinking done in postinstallscript.sh needs to be handled diffrently when AllowRoot is removed

Other:

  • Documentation will be handled in separate PR

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@madelen-at-work madelen-at-work requested a review from a team as a code owner November 2, 2023 14:39
@madelen-at-work madelen-at-work merged commit abc4664 into rootless-preview Nov 9, 2023
@madelen-at-work madelen-at-work deleted the rootless-preview-pr branch November 9, 2023 14:27
deepikas20 pushed a commit that referenced this pull request Feb 21, 2024
* rootless implementation

Co-authored-by: madelen-axis <[email protected]>
deepikas20 pushed a commit that referenced this pull request Mar 21, 2024
* rootless implementation

Co-authored-by: madelen-axis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant