Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary cleanup of AXParameter callbacks #144

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is an automatic cherry-pick of 4609395bccd4d07b48601658f1afd85b10c84586

The original PR was #235 with message:

There is no need to unregister AXParameter callbacks. The hash table used for storing them will free its contents in ax_parameter_free().

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

There is no need to unregister AXParameter callbacks.
The hash table used for storing them will free its contents in
ax_parameter_free().
@github-actions github-actions bot requested review from a team as code owners April 24, 2024 13:45
@killenheladagen killenheladagen merged commit 62011fc into main Apr 24, 2024
@killenheladagen killenheladagen deleted the cherrybot-11401 branch April 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant