Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rootlesskit instead of dockerd where relevant #131

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is an automatic cherry-pick of e22fd9ed979458dfae7c823494f95d288e17ce64

The original PR was #225 with message:

The PID returned from g_spawn_async() is that of rootlesskit, not dockerd, so it makes sense to talk about the rootlesskit process in the log_debug() statements.

Also changed so 0 rather than -1 means no child process is running.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

The PID returned from g_spawn_async() is that of rootlesskit, not
dockerd, so it makes sense to talk about the rootlesskit process in
the log_debug() statements.

Also changed so 0 rather than -1 means no child process is running.
@github-actions github-actions bot requested review from a team as code owners April 19, 2024 10:45
@killenheladagen killenheladagen merged commit 3f3b8f5 into main Apr 19, 2024
@killenheladagen killenheladagen deleted the cherrybot-13261 branch April 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant