Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acap signing #91

Merged
merged 42 commits into from
Mar 28, 2023
Merged

Acap signing #91

merged 42 commits into from
Mar 28, 2023

Conversation

kristinub
Copy link
Contributor

@kristinub kristinub commented Mar 16, 2023 •
edited
Loading

Describe your changes

Added automatic signing of the docker ACAP application.
When a new tag is created the application will be signed and uploaded to artifacts. A prerelease is created and the artifacts uploaded as assets.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@kristinub
Test signing ACAP in CI
8687686 
Change-Id: Ib7be018edf98c2eef8fa219537d63354a3f10077
@kristinub
Fix artifact path
d2d1a78 
Change-Id: I978e1be6fce79ec97bcb918cd0d5608ef8f79820
@kristinub
Merge branch 'main' into acap-signing
f3289de 
* main:
  fix to make shellcheck happy
  Use buildx and heredocs (#90)
  build.sh: Use separate build dir for each architecture

Change-Id: I142ea7edaf9da62c81ab6e6828d170bb7c48600e
@kristinub
Remove test-signing.yml
2c0373d 
Change-Id: I14f54e95d15c4817dfa5303c06ed525cf3a4e55a
@kristinub
test acap signing and prerelease
47b6b70 
Change-Id: I9865e9941d0211168d1b9752a9643c5a22e81fb5
@kristinub
test acap signing and prerelease
7fc251f 
Change-Id: I6f8e7542ea70c2b4b2a6d760423bc573027cd102
@kristinub
Test acap signing and prerel
603d7f3 
Change-Id: Ie2006f7b86919361c7986aac0965fe613f00de2d
@kristinub
test signing and prerel
2a8d1e7 
Change-Id: I5c99660a93c6818f51de7a40860f8a69a7a87c5a
@kristinub
test signing and rel
f457453 
Change-Id: I32214247be8c51e77a40624bf5767ca9ab15c59b
@kristinub
test sign and prerel igen
e53f61f 
Change-Id: I22dee89d53988b265d60a0f2d43cd92b60004605
@kristinub
test acap-signing
f6bb1e9 
Change-Id: I6adc6b3d0974a3da836a7cd967ca6e393bc83b99
@kristinub
test acap signing, error msg for prerel added
0e9b51c 
Change-Id: Id106f5a3de8332599e898030b06e25509dd57fee
@kristinub
test acap signing
d81d69c 
Change-Id: I2a96f907e6e7d3f66ddc7171d673cecc79f0f58b
@kristinub
Fix error in Sign and prerelease
bb0fda9 
Change-Id: Ic058784b17f5120233b3a1ee4894bf122482e317
@kristinub
Acap Signing
522f0e5 
Change-Id: Id7196f57d63de3c220ca7c5bcdfbfd2943dd425b
kristinub added 11 commits March 20, 2023 10:52
@kristinub
Fix after PR
26e488a 
Change-Id: Id78b3b2ea0a4a876597cae5f42156b87dc04abf7
@kristinub
Acap Signing
be7ac52 
Change-Id: I59623c92151738ee4ce9a4882e666fd8652d15d8
@kristinub
check that signing is successful
5400b17 
Change-Id: I7008e7a98b5fb2da014615a70a5b69e029f1dc25
@kristinub
Testing signing - aarch64
1a85554 
Change-Id: I9086256d70ff4efd22657599c6d69db30d2ca556
@kristinub
Testing signing - aarch64
fc546f2 
Change-Id: I4027de7be76983cf81c957ec5b16b86171ac7bbd
@kristinub
test acap signing
9705b62 
Change-Id: I50d14f4d36462c601c034650208f87004d3ee272
@kristinub
test acap signing
c9c8adc 
Change-Id: I5351c7c923dcf347daa73d44e14284485637a521
@kristinub
Readme updated
57c3006 
Change-Id: I737780eda2f95c32382268127de577c1f1291103
@kristinub
readme updated
62894c7 
Change-Id: I899ec964d0021712cc7c6f5ce8b5b73e698f6063
@kristinub
Test acap signing
495afaf 
Change-Id: Iab5552c96f37fd517a31c806e1a91d063f7fb832
@kristinub
Test Acap Signing - This should be sucessful
1a60f9c 
Change-Id: I975c0db3f5f01a9cfa05201a07dca27ebd83fc1d
@kristinub kristinub marked this pull request as ready for review March 23, 2023 14:52
@kristinub kristinub requested a review from a team as a code owner March 23, 2023 14:52
kristinub added 11 commits March 24, 2023 13:52
@kristinub
Test github-script at release
7cfbc3b 
Change-Id: I1f85defa737a6544c3ed5dbdc100ba28c030f543
@kristinub
Test github-script at release
1f385b6 
Change-Id: I77f525e1ecb7954be952aab926b90e6efb31fd68
@kristinub
Test github-script at prerel
9ed7412 
Change-Id: I5f4af4d7e3530a21ac2639f286120182204b6de2
@kristinub
test new format of eap file and github script at prerel
ecdd5b4 
Change-Id: Iff983ecedcbe8501c47c17990beaa96243e0c98b
@kristinub
test ACAP Signing
e7ff2f7 
Change-Id: I8560dea253798c5a60e3ad2eb76854e943f05bb6
@kristinub
test ACAP Signing
d99fc57 
Change-Id: Id3b9b230a4f85495de93285903527eb711db5a74
@kristinub
trying to fix path for uploading asset
21b9998 
Change-Id: I7a5614f7c67081d8f68f006f3ab4ff57c35589d3
@kristinub
testing ACAP Signing
9f7ad08 
Change-Id: Idc027d3add177946990fb88a16b55824353e2506
@kristinub
Trying to set the file permissions
cabb561 
Change-Id: I6c92093fed54e8d6319adb70281d9a46ebe49a23
@kristinub
Test acap signing
d57adfd 
Something wrong when downloading artifacts

Change-Id: I4fb30048aab584be75b5746a6c0a386130131c1a
@kristinub
test acap signing
4866429 
Change-Id: I0df45c48cff3d13f669aa4d67786aed6c6b2337c
@kristinub
Test Acap Signing
3e3dc20 
Change-Id: I990f14f81075ae56a3d603ccdda7f5e2c50aab2a
madelen-at-work
madelen-at-work reviewed Mar 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Mar 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@madelen-at-work madelen-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - mostly comments on a bit of cleanup

@kristinub
Fixes after PR
5cdd0d4 
Change-Id: I2cec870c921d2708fd3bc8690768edf726778fc9
@kristinub
Fix after PR
b0c4a84 
Change-Id: I7a0e9660a97d0022853b0ec7b67ff3c1a44979de
@madelen-at-work madelen-at-work requested a review from jojju March 27, 2023 13:53
@kristinub kristinub merged commit ca953d6 into main Mar 28, 2023
@kristinub kristinub deleted the acap-signing branch March 28, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

@jojju jojju Awaiting requested review from jojju

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristinub @madelen-at-work