Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to change ownership of files on SD card during installation #247

Merged
merged 3 commits into from
May 2, 2024
Merged

Try to change ownership of files on SD card during installation #247

merged 3 commits into from
May 2, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 30, 2024 •
edited
Loading

When 'Allow root-privileged apps' is turned on,
the post-install script will run as root,
so it has the ability to change the ownership of the files on the SD card

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen
Try to change ownership of files on SD card during installation
a89c704 
When 'Allow root-privileged apps' is turned on,
the post-install script will run as root,
so it has the ability to change the ownership of the files on the SD card
@killenheladagen killenheladagen requested review from a team as code owners April 30, 2024 13:51
madelen-at-work and others added 2 commits April 30, 2024 18:48
@madelen-at-work @killenheladagen
Updates to README (#248)
67dfcef 
* Updates to README

* Update README.md

---------

Co-authored-by: madelen-at-work <[email protected]>
Co-authored-by: Mattias Axelsson <[email protected]>
@killenheladagen
Fix according to linter
791855f
@killenheladagen killenheladagen merged commit 91e2a9e into main May 2, 2024
13 checks passed
@killenheladagen killenheladagen deleted the sd-owner branch May 2, 2024 07:19
@github-actions github-actions bot mentioned this pull request May 2, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
rootless 11.11 LTS release
Development

Successfully merging this pull request may close these issues.
2 participants
@killenheladagen @madelen-at-work