Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log missing TLS certificates as a warning rather than an error #245

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Log missing TLS certificates as a warning rather than an error #245

merged 1 commit into from
Apr 30, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 30, 2024 •
edited
Loading

TLS is enabled by default and uploading certificates over HTTP needs to happen after the application has started, so the user cannot avoid this message when using HTTP rather than SSH.

The warning message already exists in tls_log_missing_cert_certs(), so this change only removes the generic error message at the call site.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen
Log missing TLS certificates as a warning rather than an error
fbe4568 
TLS is enabled by default and uploading certificates over HTTP needs to
happen after the application has started, so the user cannot avoid this
message when using HTTP rather than SSH.

The warning message already exists in tls_log_missing_cert_certs(),
so this change only removes the generic error message at the call site.
@killenheladagen killenheladagen requested review from a team as code owners April 30, 2024 13:06
@killenheladagen killenheladagen merged commit dc53ab8 into main Apr 30, 2024
13 checks passed
@killenheladagen killenheladagen deleted the warn-tls branch April 30, 2024 16:49
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killenheladagen @madelen-at-work