Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up AXParameter callback registration code #239

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 24, 2024

  • The ax_parameters[] array has been given a name reflecting its purpose.
  • The array is now NULL-terminated, to simplify looping over it.
  • The AXParameter callback function has been given a name reflecting its purpose.
  • The unnecessary qualification of the parameter name when registering the callback has been removed.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen killenheladagen requested review from a team as code owners April 24, 2024 15:41
@killenheladagen killenheladagen merged commit aaf835e into main Apr 25, 2024
13 checks passed
@killenheladagen killenheladagen deleted the callback-cleanup branch April 25, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants