Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify concatenation of formatted strings #232

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 19, 2024

Instead of keeping track of offset into and length of buffer, keep track of pointers to next input and to end of buffer. This means one less subtraction in every call to g_snprintf() and occationally statements that don't have to span several lines.

The --tlsverify flag was also moved from tls.c to the main file.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen killenheladagen requested review from a team as code owners April 19, 2024 14:38
Base automatically changed from dry-xdg to main April 22, 2024 07:07
Instead of keeping track of offset into and length of buffer,
keep track of pointers to next input and to end of buffer.
This means one less subtraction in every call to g_snprintf()
and occationally statements that don't have to span several lines.

The --tlsverify flag was also moved from tls.c to the main file.
@killenheladagen killenheladagen merged commit 6173697 into main Apr 22, 2024
13 checks passed
@killenheladagen killenheladagen deleted the build-cmd-shorter branch April 22, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants