Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check that child process was started #222

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 18, 2024

Even if the child process dies immediately after being launched, the call to g_child_watch_add() will register a callback that will alert the application of the exit code when the main loop is reached.

In this case, status will briefly change to STATUS_RUNNING before changing to DOCKERD_RUNTIME_ERROR.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Even if the child process dies immediately after being launched,
the call to g_child_watch_add() will register a callback that will
alert the application of the exit code when the main loop is reached.

In this case, status will briefly change to STATUS_RUNNING before
changing to DOCKERD_RUNTIME_ERROR.
@killenheladagen killenheladagen requested review from a team as code owners April 18, 2024 15:10
@killenheladagen killenheladagen merged commit d0bd35b into main Apr 19, 2024
13 checks passed
@killenheladagen killenheladagen deleted the rm-child-check branch April 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants