Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set status and log errors consistently #218

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

killenheladagen
Copy link
Contributor

There were some paths were status wasn't updated.

There were some paths were multiple errors were logged, but the first one contained enough information.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

There were some paths were status wasn't updated.

There were some paths were multiple errors were logged,
but the first one contained enough information.
@killenheladagen killenheladagen requested a review from a team as a code owner April 17, 2024 13:36
@killenheladagen killenheladagen merged commit a9c4a28 into main Apr 17, 2024
13 checks passed
@killenheladagen killenheladagen deleted the set-status-comments branch April 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants