Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out function for building daemon command line #217

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 17, 2024

start_dockerd() spanned several screens, so it could benefit from being split in two.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

start_dockerd() spanned several screens, so it could benefit from being split in two.
@killenheladagen killenheladagen requested a review from a team as a code owner April 17, 2024 12:37
@killenheladagen killenheladagen merged commit aa48a45 into main Apr 17, 2024
13 checks passed
@killenheladagen killenheladagen deleted the break-up-start-dockerd branch April 17, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants