Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants for parameter names and remove trivial reader functions #172

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 4, 2024

Defining string literals in a single place reduces the risk of spelling mistakes.

The functions for reading parameter values will never fail, so checking return values is pointless.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen killenheladagen requested a review from a team as a code owner April 4, 2024 17:30
Base automatically changed from log-stdout to main April 5, 2024 13:53
Defining string literals in a single place reduces the risk of spelling
mistakes.

The functions for reading parameter values will never fail,
so checking return values is pointless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants