Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass around SD card area instead of using global constant #157

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Pass around SD card area instead of using global constant #157

merged 6 commits into from
Mar 26, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Mar 22, 2024 •
edited by madelen-at-work
Loading

Pass around data root in settings struct, also setting data-root to the default location if sd card is not selected.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen
Pass around data root in settings struct
7b1ba43 
This reverts commit ba7a3b3.
@killenheladagen
Remove handling of unknown parameters in callback
23ef43b 
Callbacks from unknown parameters isn't something that happens,
and if it did, it wouldn't be a big deal anyway.

Removing is a step towards removing global variable 'restart_dockerd'.
@killenheladagen
Centralize restart of dockerd
76a2276 
By running g_main_loop_run() in a while-loop, other parts of the
program can retry starting dockerd by simply calling
g_main_loop_quit(). To exit this loop, call quit_program(), which will
also set the global acap_exit_code variable.

This is needed then e.g. axstorage is used to wait for SD card to
become available.
@killenheladagen
Pass around SD card area instead of using global constant
f632755
@killenheladagen killenheladagen requested a review from a team as a code owner March 22, 2024 21:17
Base automatically changed from restart-dockerd to main March 25, 2024 11:59
@madelen-at-work madelen-at-work merged commit bdae738 into main Mar 26, 2024
11 of 12 checks passed
@madelen-at-work madelen-at-work deleted the pass-sd-area branch March 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killenheladagen @madelen-at-work