New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass around data root in settings struct #153

Merged

madelen-at-work merged 1 commit into main from pass-data-root

Mar 25, 2024

Contributor

killenheladagen commented Mar 22, 2024 •

edited by madelen-at-work

Loading

Simplify handling of path on SD card for by passing the path instead of a boolean when Use SD card is selected.

Checklist before requesting a review

I have performed a self-review of my own code
I have verified that the code builds perfectly fine on my local system
I have added tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have verified that my code follows the style already available in the repository
I have made corresponding changes to the documentation


          Pass around data root in settings struct

7b1ba43

This reverts commit ba7a3b3.

killenheladagen requested a review from a team as a code owner

March 22, 2024 18:26

madelen-at-work approved these changes

View reviewed changes

madelen-at-work merged commit f2084b9 into main

12 checks passed

madelen-at-work deleted the pass-data-root branch

March 25, 2024 07:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet