Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused error variable #150

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Remove unused error variable #150

merged 1 commit into from
Mar 22, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Mar 22, 2024

Since 'error' is not passed in to setup_axparameter(), it will not be set in case setup_axparameter() fails. However, it wasn't possible to get setup_axparameter() to fail. Both ax_parameter_new() and ax_parameter_register_callback() are apparently valid to call even with a non-existing application name.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Since 'error' is not passed in to setup_axparameter(), it will not be
set in case setup_axparameter() fails. However, it wasn't possible to
get setup_axparameter() to fail. Both ax_parameter_new() and
ax_parameter_register_callback() are apparently valid to call even
with a non-existing application name.
@killenheladagen killenheladagen requested a review from a team as a code owner March 22, 2024 14:32
@madelen-at-work madelen-at-work merged commit 4ec6dbd into main Mar 22, 2024
12 checks passed
@madelen-at-work madelen-at-work deleted the rm-unused-error branch March 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants