Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package settings in a struct and reduce code duplication #139

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Package settings in a struct and reduce code duplication #139

merged 3 commits into from
Mar 21, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Mar 20, 2024 •
edited
Loading

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen killenheladagen requested a review from a team as a code owner March 20, 2024 09:26
deepikas20
deepikas20 reviewed Mar 21, 2024
View reviewed changes
app/dockerdwrapper.c Outdated Show resolved Hide resolved
killenheladagen
killenheladagen commented Mar 21, 2024
View reviewed changes
app/dockerdwrapper.c Outdated Show resolved Hide resolved
@killenheladagen killenheladagen merged commit 91a1e03 into main Mar 21, 2024
12 checks passed
@killenheladagen killenheladagen deleted the settings-struct branch March 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

@deepikas20 deepikas20 deepikas20 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killenheladagen @deepikas20 @madelen-at-work