feat(Infos): allow ReactNode in word and definition infos #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| expect(asFragment).toMatchSnapshot(); |
There was a problem hiding this comment.
on supprime le snapshot ?
There was a problem hiding this comment.
Je suis parti pour le supprimer et faire plutôt un test via testing-library, mais si on veut le conserver ça ne me dérange pas.
There was a problem hiding this comment.
non pas de souci, par contre tu peux vérifier tous les autres éléments (definition, id), stp. ?
There was a problem hiding this comment.
Fait, seul l'id pour lequel je ne vois pas comment le tester, car il est utilisé uniquement dans les attributs key qui n'apparaisse pas dans le dom et donc ne sont pas atteignables. Sauf si tu vois une manière de le faire que je ne connaitrais pas. En tout cas, le coverage est à 100%.
arnaudforaison
requested changes
Apr 29, 2022
MartinWeb
force-pushed
the
feat/infosClassName
branch
from
e234cbc to
a641e67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
The Infos component doesn't allow to put a style on the word or the definition. It could be nice to give that opportunity to allow the consumer to style one particular definition or word.
Reference to the issue
#964
Person(s) for reviewing proposed changes
@arnaudforaison @samuel-gomez