fix(modal): add classModifier prop #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeb
reviewed
Apr 8, 2022
| export type ModalCoreProps = ModalCoreComponentProps & WithClassModifierOptions; | ||
|
|
||
| const enhance = compose( | ||
| identity<ModalCoreComponentProps>(), |
There was a problem hiding this comment.
Est-ce qu'il ne faudrait pas mettre ModalCoreProps comme type ici pour avoir accès au classModifier ?
There was a problem hiding this comment.
bien vu, done
Debaerdm
previously approved these changes
Apr 8, 2022
MartinWeb
previously approved these changes
Apr 12, 2022
| @@ -5,6 +5,9 @@ | |||
| animation: fademodal 0.1s linear; | |||
| z-index: 3; | |||
| overflow: auto; | |||
| &--after-open { | |||
| background: rgba(48, 50, 191, 0.62) !important; | |||
There was a problem hiding this comment.
Est ce qu'on ne prendrais pas une couleur déjà définie ou on la définie ? Pourquoi le important ?
There was a problem hiding this comment.
exact, on peut utiliser une variable, par contre pour le important, je n'ai pas trouvé d'autres solutions car le css est mis en inline sur react-modal :
arnaudforaison
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
regression sur les modifier des modals
Person(s) for reviewing proposed changes
@arnaudforaison
Important
Before creating a pull request run unit tests