Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/paging component #954

Closed
wants to merge 2 commits into from

Conversation

jmittelette
Copy link
Contributor

@jmittelette jmittelette commented Mar 15, 2022

Related issue

close #918

Reference to the issue

Here you can add link to related issue

Description of the issue

Your description

Person(s) for reviewing proposed changes

You can add @mention here

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@@ -74,6 +75,7 @@ class Paging extends React.PureComponent<PagingComponentProps> {
<Items
onChange={this.onChangeItems}
numberItems={numberItems}
items={items}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas vu de tests unitaires associés à cet ajout de prop.
Peux-tu ajouter des cas de tests, stp ?
Et encore mieux, il faudrait en profiter pour passer ce composant à 100% de couverture :
image

@MartinWeb
Copy link
Contributor

Le besoin a été traité au sein de cette pull request #1017
Je clôture.

@MartinWeb MartinWeb closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Paging] - Impossible to pass items variable to Items component, which is used by Paging component
3 participants