feature(helpmessage): change type helpmessage #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudforaison
force-pushed
the
feature/allow-jsx-help-message-#939
branch
2 times, most recently
from
481c0ad to
12321d9
Compare
samuel-gomez-axa
force-pushed
the
feature/allow-jsx-help-message-#939
branch
from
12321d9 to
11992bc
Compare
arnaudforaison
requested changes
Dec 10, 2021
|
|
||
| type HelpProps = { | ||
| message?: string; | ||
| type HelpProps = HTMLProps<HTMLSpanElement> & { |
There was a problem hiding this comment.
Suggested change
| type HelpProps = HTMLProps<HTMLSpanElement> & { | |
| type HelpProps = React.ComponentPropsWithoutRef<"small"> & { |
arnaudforaison
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#939
Description of the issue
Person(s) for reviewing proposed changes
@arnaudforaison